Change manifests generation#74
Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom Oct 29, 2019
Merged
Conversation
In k8s 1.16 "--donain" option was removed from controller-gen, so now we have to explicitly specify paths to our apis and the output directory.
openshift-ci-robot
added
approved
|
/test e2e-openstack |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Fedosin, iamemilio The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
racheljpg
pushed a commit
to racheljpg/cluster-api-provider-openstack
that referenced
this pull request
Dec 20, 2023
Depending on the arguments passed to kubeadm, it may or may not output more data to stdout. Since we're shelling out and depending on the kubeadm cli to generate the token, this commit fixes the token parsing by splitting the output into lines and getting the very last one. This is far from ideal, as in we should not be depending on kubeadm to generate the token. Until that is fixed, this patch seems to be a good compromise. Closes openshift#74
pierreprinetti
pushed a commit
to shiftstack/cluster-api-provider-openstack
that referenced
this pull request
Apr 22, 2024
Depending on the arguments passed to kubeadm, it may or may not output more data to stdout. Since we're shelling out and depending on the kubeadm cli to generate the token, this commit fixes the token parsing by splitting the output into lines and getting the very last one. This is far from ideal, as in we should not be depending on kubeadm to generate the token. Until that is fixed, this patch seems to be a good compromise. Closes openshift#74
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In k8s 1.16 "--domain" option was removed from controller-gen, so now we have to explicitly specify paths to our apis and the output directory.