[release-4.4] Bug 1832999: Migrate to MAO by Fedosin · Pull Request #98 · openshift/cluster-api-provider-openstack

Fedosin · 2020-06-05T16:22:00Z

Cherry-picked from: #90

openshift-ci-robot · 2020-06-05T16:22:04Z

@Fedosin: This pull request references Bugzilla bug 1811400, which is invalid:

expected the bug to be open, but it isn't
expected the bug to target the "4.4.z" release, but it targets "4.5.0" instead
expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is CLOSED (DUPLICATE) instead
expected Bugzilla bug 1811400 to depend on a bug targeting a release in 4.5.0, 4.5.z and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[release-4.4] Bug 1811400: Migrate to MAO

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-06-05T16:26:38Z

@Fedosin: This pull request references Bugzilla bug 1832999, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.4.z) matches configured target release for branch (4.4.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1810400 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
dependent Bugzilla bug 1810400 targets the "4.5.0" release, which is one of the valid target releases: 4.5.0, 4.5.z
bug has dependents

Details

In response to this:

[release-4.4] Bug 1832999: Migrate to MAO

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

iamemilio · 2020-06-05T18:38:22Z

/lgtm
/hold until it passes

Fedosin · 2020-06-07T09:08:57Z

/test e2e-openstack

Fedosin · 2020-06-07T10:02:11Z

/test e2e-openstack

mandre · 2020-06-08T06:30:35Z

/test e2e-openstack

mandre · 2020-06-08T09:08:36Z

Seems like the worker nodes didn't get provisioned:
https://deck-ci.apps.ci.l2s4.p1.openshiftapps.com/view/gcs/origin-ci-test/pr-logs/pull/openshift_cluster-api-provider-openstack/98/pull-ci-openshift-cluster-api-provider-openstack-release-4.4-e2e-openstack/13

Fedosin · 2020-06-08T13:06:53Z

/test e2e-openstack

Co-authored-by: Mike Fedosin <mfedosin@redhat.com>

Co-authored-by: Emilio Garcia <egarcia@redhat.com>

mandre · 2020-06-08T16:11:43Z

/lgtm

mandre · 2020-06-08T16:12:19Z

/hold cancel

Fedosin · 2020-06-18T17:56:50Z

/hold

bparees · 2020-06-18T19:47:29Z

@iamemilio this is passing, is it ready to be unheld and cherry pick approved?

Fedosin · 2020-06-19T10:13:31Z

/hold cancel

Fedosin · 2020-06-19T10:18:06Z

@bparees yes, it's ready to merge... I put the hold to make sure #102 passes the tests.
It would be really nice if we can merge them together, I mean #98 and the 4.4 backport of #102

sdodson · 2020-06-19T13:51:00Z

/hold
unclear to me whether we're saying we need to include #102 in this change in order to prevent regressions or not

bparees · 2020-06-19T15:09:10Z

4.4.z boat is now full so this can be revisited next week i guess.

pierreprinetti · 2020-06-19T15:11:36Z

@Fedosin
Do you think that the severity of this bug is really "medium"? Is it possible to stand up a 4.4 cluster on OpenStack without this patch?

CC @iamemilio

Cherry-picked from: openshift#101 Co-authored-by: Emilio Garcia <egarcia@redhat.com>

iamemilio · 2020-06-19T18:13:43Z

/lgtm

openshift-ci-robot · 2020-06-19T18:13:51Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Fedosin, iamemilio, mandre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [Fedosin,iamemilio,mandre]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

iamemilio · 2020-06-19T18:14:53Z

Holding until https://bugzilla.redhat.com/show_bug.cgi?id=1848755 is VERIFIED

pierreprinetti · 2020-07-01T16:42:53Z

https://bugzilla.redhat.com/show_bug.cgi?id=1848755 is verified.

This is ready for the cherry-pick-approval! 🚀

pierreprinetti · 2020-07-01T16:44:01Z

/hold cancel

openshift-ci-robot · 2020-07-03T12:29:45Z

@Fedosin: All pull requests linked via external trackers have merged: openshift/cluster-api-provider-openstack#98. Bugzilla bug 1832999 has been moved to the MODIFIED state.

Details

In response to this:

[release-4.4] Bug 1832999: Migrate to MAO

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 5, 2020

openshift-ci-robot requested review from iamemilio and tomassedovic June 5, 2020 16:22

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 5, 2020

Fedosin changed the title ~~[release-4.4] Bug 1811400: Migrate to MAO~~ [release-4.4] Bug 1832999: Migrate to MAO Jun 5, 2020

openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. and removed bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. labels Jun 5, 2020

openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 5, 2020

iamemilio mentioned this pull request Jun 5, 2020

[release-4.4]Bug 1832999: Migrate to MAO #94

Closed

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 5, 2020

openshift-ci-robot assigned iamemilio Jun 5, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 5, 2020

Fedosin force-pushed the go_mod_44 branch from a90604c to aae77a7 Compare June 8, 2020 14:16

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jun 8, 2020

Emilio Garcia and others added 2 commits June 8, 2020 16:17

Use go mod

03fa244

Co-authored-by: Mike Fedosin <mfedosin@redhat.com>

Port CAPO to MAO API

a349411

Co-authored-by: Emilio Garcia <egarcia@redhat.com>

Fedosin force-pushed the go_mod_44 branch from aae77a7 to a349411 Compare June 8, 2020 14:18

openshift-ci-robot assigned mandre Jun 8, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 8, 2020

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 8, 2020

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 18, 2020

pierreprinetti mentioned this pull request Jun 19, 2020

Bug 1848755: Revendor MAO and client-go #102

Merged

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 19, 2020

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 19, 2020

Revendor MAO and client-go

bcd2f6e

Cherry-picked from: openshift#101 Co-authored-by: Emilio Garcia <egarcia@redhat.com>

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jun 19, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 19, 2020

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 1, 2020

sdodson added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jul 3, 2020

openshift-merge-robot merged commit d8dc8cd into openshift:release-4.4 Jul 3, 2020

Conversation

Fedosin commented Jun 5, 2020

Uh oh!

openshift-ci-robot commented Jun 5, 2020

Uh oh!

openshift-ci-robot commented Jun 5, 2020

Uh oh!

iamemilio commented Jun 5, 2020

Uh oh!

Fedosin commented Jun 7, 2020

Uh oh!

Fedosin commented Jun 7, 2020

Uh oh!

mandre commented Jun 8, 2020

Uh oh!

mandre commented Jun 8, 2020

Uh oh!

Fedosin commented Jun 8, 2020

Uh oh!

mandre commented Jun 8, 2020

Uh oh!

mandre commented Jun 8, 2020

Uh oh!

Fedosin commented Jun 18, 2020

Uh oh!

bparees commented Jun 18, 2020

Uh oh!

Fedosin commented Jun 19, 2020

Uh oh!

Fedosin commented Jun 19, 2020

Uh oh!

sdodson commented Jun 19, 2020

Uh oh!

bparees commented Jun 19, 2020

Uh oh!

pierreprinetti commented Jun 19, 2020

Uh oh!

iamemilio commented Jun 19, 2020

Uh oh!

openshift-ci-robot commented Jun 19, 2020

Uh oh!

iamemilio commented Jun 19, 2020

Uh oh!

pierreprinetti commented Jul 1, 2020

Uh oh!

pierreprinetti commented Jul 1, 2020

Uh oh!

openshift-ci-robot commented Jul 3, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants