Skip to content

Remove duplicated platform list in cloud tests#121

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
JoelSpeed:deduplicate-platform-list
Sep 13, 2021
Merged

Remove duplicated platform list in cloud tests#121
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
JoelSpeed:deduplicate-platform-list

Conversation

@JoelSpeed
Copy link
Copy Markdown
Contributor

While reviewing the alibaba introduction to CCCMO I realised we have this same list duplicated across 3 different test suites. The likelihood of them getting out of sync is very high as we add more platforms.
To make this less likely, I've moved the list into a function so that we just call the function to return all of the platforms across each of the tests that need this list.

@openshift-ci openshift-ci Bot requested review from Fedosin and mdbooth September 13, 2021 09:13
Copy link
Copy Markdown
Contributor

@Fedosin Fedosin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 13, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 13, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Fedosin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 13, 2021
@openshift-bot
Copy link
Copy Markdown

/retest-required

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Copy Markdown

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 13, 2021

@JoelSpeed: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack-ccm 75a45f7 link false /test e2e-openstack-ccm
ci/prow/e2e-azure-ccm-install 75a45f7 link false /test e2e-azure-ccm-install
ci/prow/e2e-azure-ccm 75a45f7 link false /test e2e-azure-ccm
ci/prow/e2e-azure-upgrade 75a45f7 link false /test e2e-azure-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Copy Markdown

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Copy Markdown

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 78f894d into openshift:master Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants