Skip to content

Revert "Add label to include in CI release images"#14

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
wking:drop-from-release-image
Feb 9, 2021
Merged

Revert "Add label to include in CI release images"#14
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
wking:drop-from-release-image

Conversation

@wking
Copy link
Copy Markdown
Member

@wking wking commented Feb 9, 2021

This reverts commit 184c512, #7.

This is breaking release promotion, with failures like:

ClusterOperators should define at least one namespace in their lists of related objects

Please don't add yourself to the release image until you have a presubmit running the standard break-the-world e2e suite.

This reverts commit 184c512.

This is breaking release promotion, with failures like [1]:

  ClusterOperators should define at least one namespace in their lists of related objects

Please don't add yourself to the release image until you have a
presubmit running the standard break-the-world e2e suite.

[1]: https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/release-openshift-origin-installer-e2e-gcp-4.8/1359162296110157824
@Danil-Grigorev
Copy link
Copy Markdown

/approve
/lgtm

@openshift-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Danil-Grigorev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 9, 2021
@openshift-merge-robot openshift-merge-robot merged commit 886c466 into openshift:master Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants