[OCPCLOUD-1110] Add e2e tests for managed resources provisioning#17
Conversation
Danil-Grigorev
changed the title
|
/retest |
1 similar comment
|
/retest |
|
@Danil-Grigorev: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
| }), | ||
| Entry("Should not provision resources for unknown platform", testCase{ | ||
| status: &configv1.InfrastructureStatus{ | ||
| Platform: configv1.GCPPlatformType, |
There was a problem hiding this comment.
Why to we use configv1.GCPPlatformType here?
There was a problem hiding this comment.
ATM GCP is not supported, so it made sense to mark it like this.
| Expect(equality.Semantic.DeepDerivative(original, applied)).To(BeTrue()) | ||
| } | ||
| }, | ||
| Entry("Should provision AWS resources", testCase{ |
There was a problem hiding this comment.
What about adding openstack resources here as well? https://github.com/openshift/cluster-cloud-controller-manager-operator/blob/master/pkg/cloud/openstack/openstack.go#L19
There was a problem hiding this comment.
Now that the PR is merged, sure
Danil-Grigorev
force-pushed
the
managed-resources-e2e
branch
from
6bba92a to
f96d3ea
Compare
Danil-Grigorev
force-pushed
the
managed-resources-e2e
branch
from
f96d3ea to
3aefc6d
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Fedosin The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
4 participants
Add a test case for provisioning managed resources. Was tested locally on #15, but will later require some changes in the way we configure flags on the deployment. This change although is self sufficient.