OCPCLOUD-2052: Rebase to 1.27 by odvarkadaniel · Pull Request #252 · openshift/cluster-cloud-controller-manager-operator

odvarkadaniel · 2023-05-22T10:03:31Z

This PR rebases the repo to 1.27 k8s packages.

openshift-ci-robot · 2023-05-22T10:03:35Z

@odvarkadaniel: This pull request references OCPCLOUD-2052 which is a valid jira issue.

Details

In response to this:

This PR rebases the repo to 1.27 k8s packages.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

odvarkadaniel · 2023-05-22T13:44:52Z

All the remarks mentioned above are addressed in the latest commit.

JoelSpeed

/lgtm
/approve

Lets see what the tests think

JoelSpeed · 2023-05-22T13:52:13Z


 var cfg *rest.Config
 var cl client.Client
+var ctx = context.Background()


Bonus points for being alphabetically sorted 👍

openshift-ci · 2023-05-22T13:58:24Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [JoelSpeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

odvarkadaniel · 2023-05-22T14:38:31Z

/test unit

odvarkadaniel · 2023-05-22T19:47:18Z

/retest-required

odvarkadaniel · 2023-05-23T08:11:38Z

/retest-required

JoelSpeed · 2023-05-23T09:37:00Z

/hold

@odvarkadaniel I think there's something that needs investigating here, see the failures in the unit test

There were failures detected in the following suites:
                              azure ./pkg/cloud/azure [Compilation failure]
                            powervs ./pkg/cloud/powervs [Compilation failure]
                        controllers ./pkg/controllers [Compilation failure]
                         azurestack ./pkg/cloud/azurestack [Compilation failure]
                      resourceapply ./pkg/controllers/resourceapply [Compilation failure]
  azure-config-credentials-injector ./cmd/azure-config-credentials-injector [Compilation failure]
                                aws ./pkg/cloud/aws [Compilation failure]
                          openstack ./pkg/cloud/openstack [Suite did not run because the timeout elapsed]
                              cloud ./pkg/cloud [Compilation failure]
                             common ./pkg/cloud/common [Compilation failure]
                         restmapper ./pkg/restmapper [Suite did not run because the timeout elapsed]
                                ibm ./pkg/cloud/ibm [Compilation failure]
                            vsphere ./pkg/cloud/vsphere [Suite did not run because the timeout elapsed]
                             config ./pkg/config [Compilation failure]
                            alibaba ./pkg/cloud/alibaba [Compilation failure]
                            nutanix ./pkg/cloud/nutanix [Compilation failure]
                                gcp ./pkg/cloud/gcp [Compilation failure]

odvarkadaniel · 2023-05-23T13:28:19Z

/test unit

odvarkadaniel · 2023-05-23T14:54:15Z

/test unit

odvarkadaniel · 2023-05-27T07:52:56Z

/retest

JoelSpeed · 2023-05-30T10:19:29Z

/lgtm

odvarkadaniel · 2023-05-30T10:47:26Z

/test unit

JoelSpeed · 2023-05-30T15:50:27Z

Unit tests timed out after 4 hours, sounds like there's something wrong, can they be run locally from this PR?

JoelSpeed · 2023-05-31T12:13:48Z

CCMO is degraded in the E2E tests now, will need further investigation

odvarkadaniel · 2023-05-31T12:13:49Z

Cluster installs are failing for all providers but aws for some reason. I don't really see why, will look into this tomorrow again.
The issue with unit tests is also pretty random, experienced it a couple of times already while working on PR, though only with CI runs - local runs work fine.

JoelSpeed · 2023-06-01T08:18:19Z

/lgtm
/retest

JoelSpeed · 2023-06-01T13:53:24Z

/lgtm

Lets see what the tests think now

odvarkadaniel · 2023-06-01T16:44:59Z

/retest

openshift-ci · 2023-06-01T19:13:07Z

@odvarkadaniel: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

sunzhaohua2 · 2023-06-05T05:47:02Z

/label qe-approved

dgoodwin · 2023-06-06T11:01:00Z

/label jira/valid-bug

JoelSpeed · 2023-06-06T11:17:36Z

/hold cancel

Stale hold

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 22, 2023

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 22, 2023

openshift-ci Bot requested review from JoelSpeed and damdo May 22, 2023 10:07

odvarkadaniel force-pushed the rebase-k8s-packages branch from 0649800 to 155f75d Compare May 22, 2023 10:13

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 22, 2023

odvarkadaniel force-pushed the rebase-k8s-packages branch from 155f75d to d3ef97f Compare May 22, 2023 10:58

JoelSpeed reviewed May 22, 2023

View reviewed changes

Comment thread pkg/controllers/cache.go Outdated

Comment thread pkg/controllers/clusteroperator_controller.go Outdated

Comment thread pkg/controllers/clusteroperator_controller_test.go Outdated

Comment thread pkg/restmapper/restmapper.go

Comment thread pkg/restmapper/restmapper_test.go Outdated

odvarkadaniel force-pushed the rebase-k8s-packages branch 2 times, most recently from 854f504 to e54809a Compare May 22, 2023 13:44

JoelSpeed reviewed May 22, 2023

View reviewed changes

openshift-ci Bot assigned JoelSpeed May 22, 2023

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 22, 2023

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 22, 2023

adriengentil mentioned this pull request May 22, 2023

OCPCLOUD-2010: Re-vendor api and library-go for external platform support #253

Merged

openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 23, 2023

Rebase to 1.27

2729e4f

odvarkadaniel force-pushed the rebase-k8s-packages branch from e54809a to 2729e4f Compare May 23, 2023 12:15

openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label May 23, 2023

Add subresources status to fake client builders

8b41788

Bump controller-runtime to v0.15.0

f550d93

Bump openshift/api, client-go and library-go

031f4e5

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 30, 2023

Bump controller-runtime/tools/setup-envtest

359d98c

openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label May 31, 2023

openshift-ci Bot added lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. labels Jun 1, 2023

JoelSpeed reviewed Jun 1, 2023

View reviewed changes

Comment thread cmd/config-sync-controllers/main.go Outdated

odvarkadaniel force-pushed the rebase-k8s-packages branch from 571c106 to 05d2664 Compare June 1, 2023 13:06

JoelSpeed reviewed Jun 1, 2023

View reviewed changes

Comment thread cmd/config-sync-controllers/main.go Outdated

odvarkadaniel force-pushed the rebase-k8s-packages branch from 05d2664 to 2b5dd4b Compare June 1, 2023 13:17

Fix operator being degraded in e2e tests

a3405c5

odvarkadaniel force-pushed the rebase-k8s-packages branch from 2b5dd4b to a3405c5 Compare June 1, 2023 13:18

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 1, 2023

openshift-ci Bot added the qe-approved Signifies that QE has signed off on this PR label Jun 5, 2023

openshift-ci Bot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Jun 6, 2023

openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 6, 2023

openshift-merge-robot merged commit 9f8abb9 into openshift:master Jun 6, 2023

Conversation

odvarkadaniel commented May 22, 2023

Uh oh!

openshift-ci-robot commented May 22, 2023 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

odvarkadaniel commented May 22, 2023

Uh oh!

JoelSpeed left a comment

Choose a reason for hiding this comment

Uh oh!

JoelSpeed May 22, 2023

Choose a reason for hiding this comment

Uh oh!

openshift-ci Bot commented May 22, 2023

Uh oh!

odvarkadaniel commented May 22, 2023

Uh oh!

odvarkadaniel commented May 22, 2023

Uh oh!

odvarkadaniel commented May 23, 2023

Uh oh!

JoelSpeed commented May 23, 2023

Uh oh!

odvarkadaniel commented May 23, 2023

Uh oh!

odvarkadaniel commented May 23, 2023

Uh oh!

odvarkadaniel commented May 27, 2023

Uh oh!

JoelSpeed commented May 30, 2023

Uh oh!

odvarkadaniel commented May 30, 2023

Uh oh!

JoelSpeed commented May 30, 2023

Uh oh!

JoelSpeed commented May 31, 2023

Uh oh!

odvarkadaniel commented May 31, 2023

Uh oh!

JoelSpeed commented Jun 1, 2023

Uh oh!

Uh oh!

Uh oh!

JoelSpeed commented Jun 1, 2023

Uh oh!

odvarkadaniel commented Jun 1, 2023

Uh oh!

openshift-ci Bot commented Jun 1, 2023

Uh oh!

sunzhaohua2 commented Jun 5, 2023

Uh oh!

dgoodwin commented Jun 6, 2023

Uh oh!

JoelSpeed commented Jun 6, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

openshift-ci-robot commented May 22, 2023 •

edited by openshift-ci Bot

Loading