Add images config map#28
Conversation
|
/retest |
1 similar comment
|
/retest |
| @@ -0,0 +1,11 @@ | |||
| apiVersion: v1 | |||
There was a problem hiding this comment.
Do we also need an image-references as we do in MAO to get the images substituted correctly? https://github.com/openshift/machine-api-operator/blob/master/install/image-references
There was a problem hiding this comment.
Yeah, right. I added these lines in the file 👍
There was a problem hiding this comment.
there is an image-reference below, is that not sufficient?
There was a problem hiding this comment.
It is sufficient, but it wasn't there when I reviewed ;)
Mount config map into CCCMO deployment for correct image version evaluation on operator startup. Images will be dynamically passed to operand controllers.
Danil-Grigorev
force-pushed
the
images-config-map
branch
from
addce98 to
0f345c6
Compare
|
@Danil-Grigorev: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest |
elmiko
left a comment
elmiko
left a comment
There was a problem hiding this comment.
this makes sense to me, curious about Joel's comment.
| @@ -0,0 +1,11 @@ | |||
| apiVersion: v1 | |||
There was a problem hiding this comment.
there is an image-reference below, is that not sufficient?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elmiko The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
5 participants
Mount config map into
CCCMOdeployment for correct image versionevaluation on operator startup. Images will be dynamically passed to
operand controllers.
To deploy operator locally you now need to specify a command line argument: