Revert "Revert "Add images config map""#31
Conversation
openshift-ci-robot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
Danil-Grigorev
force-pushed
the
revert-30-revert-28-images-config-map
branch
from
2f35cd2 to
4631475
Compare
| volumes: | ||
| - name: images | ||
| configMap: | ||
| defaultMode: 420 |
There was a problem hiding this comment.
is this the proper mode?
chmod 420 produces -r---w---- which doesn't look right to me.
- Fix potantial name clash in image stream tags - Add missing configMap annotations
Danil-Grigorev
force-pushed
the
revert-30-revert-28-images-config-map
branch
from
4631475 to
9caa0e9
Compare
elmiko
left a comment
elmiko
left a comment
There was a problem hiding this comment.
@Danil-Grigorev this looks fine to me, but i think we should update the image urls now since we are adding them
| @@ -0,0 +1,4 @@ | |||
| { | |||
| "cloudControllerManagerAWS": "registry.svc.ci.openshift.org/openshift:aws-cloud-controller-manager", | |||
| "cloudControllerManagerOpenStack": "registry.svc.ci.openshift.org/openshift:openstack-cloud-controller-manager" | |||
There was a problem hiding this comment.
we should probably fix these up before committing. no reason to use the old url
There was a problem hiding this comment.
Right, let me adjust that. CI is now passing
| images.json: > | ||
| { | ||
| "cloudControllerManagerAWS": "registry.svc.ci.openshift.org/openshift:aws-cloud-controller-manager", | ||
| "cloudControllerManagerOpenStack": "registry.svc.ci.openshift.org/openshift:openstack-cloud-controller-manager" |
| - name: aws-cloud-controller-manager | ||
| from: | ||
| kind: DockerImage | ||
| name: registry.svc.ci.openshift.org/openshift:aws-cloud-controller-manager |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elmiko The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
5 participants
Reverts #30