Skip to content

Add anti-affinity settings to preserve HA for CCM pods#33

Merged
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
Danil-Grigorev:affinity-settings
Apr 21, 2021
Merged

Add anti-affinity settings to preserve HA for CCM pods#33
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
Danil-Grigorev:affinity-settings

Conversation

@Danil-Grigorev
Copy link
Copy Markdown

Following proposal we need to run at least 2 replicas of CCM
controllers scheduled on different master nodes for HA:
https://github.com/openshift/enhancements/pull/463/files#diff-3e0e2c48e70215076dfe36c13768a823ab7080d929d80292f37db2ef5a2121e8R123

Requires pieces from #15 to be merged first.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 16, 2021
@openshift-ci-robot
Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@JoelSpeed
Copy link
Copy Markdown
Contributor

Changes in this look ok to me, will need to see the base PR merge first though

Danil-Grigorev added 2 commits April 20, 2021 11:14
According to proposal we need to run at least 2 replicas of CCM
controllers scheduled on different master nodes for HA.
@Danil-Grigorev Danil-Grigorev marked this pull request as ready for review April 20, 2021 09:15
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 20, 2021
@Danil-Grigorev
Copy link
Copy Markdown
Author

/retest

@JoelSpeed
Copy link
Copy Markdown
Contributor

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 20, 2021
@Danil-Grigorev
Copy link
Copy Markdown
Author

/retest

Copy link
Copy Markdown
Contributor

@elmiko elmiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i am not super familiar with the antiaffinity settings, but this generally looks good to me.
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 20, 2021
@openshift-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elmiko, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Copy Markdown

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Copy Markdown

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown

/retest

Please review the full test history for this PR and help us cut down flakes.

@JoelSpeed
Copy link
Copy Markdown
Contributor

/retest

1 similar comment
@Danil-Grigorev
Copy link
Copy Markdown
Author

/retest

@openshift-bot
Copy link
Copy Markdown

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 0bf6de0 into openshift:master Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants