Add anti-affinity settings to preserve HA for CCM pods#33
Conversation
|
Skipping CI for Draft Pull Request. |
|
Changes in this look ok to me, will need to see the base PR merge first though |
According to proposal we need to run at least 2 replicas of CCM controllers scheduled on different master nodes for HA.
2e67b4d to
bd6a74f
Compare
|
/retest |
|
/approve |
|
/retest |
elmiko
left a comment
There was a problem hiding this comment.
i am not super familiar with the antiaffinity settings, but this generally looks good to me.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elmiko, JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest |
1 similar comment
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Following proposal we need to run at least 2 replicas of CCM
controllers scheduled on different master nodes for HA:
https://github.com/openshift/enhancements/pull/463/files#diff-3e0e2c48e70215076dfe36c13768a823ab7080d929d80292f37db2ef5a2121e8R123
Requires pieces from #15 to be merged first.