Skip to content

Improve operator status management#40

Merged
openshift-merge-robot merged 7 commits intoopenshift:masterfrom
Danil-Grigorev:refactor-operator-status
May 17, 2021
Merged

Improve operator status management#40
openshift-merge-robot merged 7 commits intoopenshift:masterfrom
Danil-Grigorev:refactor-operator-status

Conversation

@Danil-Grigorev
Copy link
Copy Markdown

@Danil-Grigorev Danil-Grigorev commented May 11, 2021

Operator correctly reports degraded and available conditions during reconcile.

  • Distribute methods into packages where they belong.
  • Add events on resource updates, cluster operator changes.
  • Report progressing condition on cluster upgrade or resources change.

@openshift-ci openshift-ci Bot requested review from Fedosin and JoelSpeed May 11, 2021 10:19
Comment thread controllers/clusteroperator_controller.go Outdated
Comment thread controllers/status.go Outdated
Comment thread controllers/status.go Outdated
@Danil-Grigorev Danil-Grigorev force-pushed the refactor-operator-status branch 2 times, most recently from 9ad3f3c to 9632221 Compare May 14, 2021 08:12
@Danil-Grigorev Danil-Grigorev requested a review from JoelSpeed May 14, 2021 08:15
@Danil-Grigorev Danil-Grigorev force-pushed the refactor-operator-status branch 3 times, most recently from 4a3ed9a to 72ea1ac Compare May 14, 2021 08:52
Comment thread controllers/clusteroperator_controller.go Outdated
Comment thread controllers/config_test.go
Comment thread controllers/status.go Outdated
@Danil-Grigorev Danil-Grigorev force-pushed the refactor-operator-status branch from 72ea1ac to 600422d Compare May 14, 2021 11:32
Comment thread controllers/clusteroperator_controller.go
Comment thread controllers/clusteroperator_controller_test.go Outdated
Comment thread controllers/status.go Outdated
Comment thread controllers/status.go Outdated
Comment thread controllers/status.go Outdated
Comment thread controllers/status.go Outdated
@Danil-Grigorev Danil-Grigorev force-pushed the refactor-operator-status branch from 600422d to be5a72f Compare May 17, 2021 11:55
@openshift-ci openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 17, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 17, 2021

@Danil-Grigorev: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-ccm be5a72f link /test e2e-aws-ccm

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Danil-Grigorev Danil-Grigorev force-pushed the refactor-operator-status branch from be5a72f to 95ee82a Compare May 17, 2021 12:17
@openshift-ci openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 17, 2021
@lobziik
Copy link
Copy Markdown
Contributor

lobziik commented May 17, 2021

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 17, 2021
@JoelSpeed
Copy link
Copy Markdown
Contributor

/approve

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 17, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 17, 2021
@openshift-merge-robot openshift-merge-robot merged commit 657da10 into openshift:master May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants