Skip to content

Revendor library-go and openshift/api for Azure Stack Hub and Azure support#77

Merged
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
Danil-Grigorev:revendor-azure-library-go
Jul 12, 2021
Merged

Revendor library-go and openshift/api for Azure Stack Hub and Azure support#77
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
Danil-Grigorev:revendor-azure-library-go

Conversation

@Danil-Grigorev
Copy link
Copy Markdown

@Danil-Grigorev Danil-Grigorev commented Jul 2, 2021

Includes revendoring after openshift/library-go#895 and openshift/library-go#1077 changes were merged.

@openshift-ci openshift-ci Bot requested review from Fedosin and mandre July 2, 2021 11:14
lobziik
lobziik reviewed Jul 2, 2021
View reviewed changes
Comment thread pkg/controllers/clusteroperator_controller.go
@Fedosin
Copy link
Copy Markdown
Contributor

Fedosin commented Jul 2, 2021

/test verify

@lobziik
Copy link
Copy Markdown
Contributor

lobziik commented Jul 2, 2021

/test verify

Rebase needed

@Danil-Grigorev Danil-Grigorev force-pushed the revendor-azure-library-go branch from 141884e to 02a0896 Compare July 8, 2021 15:11
@Danil-Grigorev Danil-Grigorev requested a review from lobziik July 8, 2021 15:13
@Danil-Grigorev Danil-Grigorev force-pushed the revendor-azure-library-go branch 2 times, most recently from 3d14363 to 9a0ae3e Compare July 8, 2021 15:20
@Danil-Grigorev Danil-Grigorev requested a review from JoelSpeed July 8, 2021 15:21
@Danil-Grigorev Danil-Grigorev force-pushed the revendor-azure-library-go branch from 9a0ae3e to 77010a7 Compare July 8, 2021 15:24
@lobziik
Copy link
Copy Markdown
Contributor

lobziik commented Jul 8, 2021 •
edited
Loading

/approve

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jul 8, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lobziik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 8, 2021
@lobziik
Copy link
Copy Markdown
Contributor

lobziik commented Jul 8, 2021

/lgtm cancel

Would be nice to have another pair of eyes

@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2021
JoelSpeed
JoelSpeed reviewed Jul 8, 2021
View reviewed changes
Comment thread pkg/config/config_test.go
Comment thread pkg/controllers/clusteroperator_controller.go
@lobziik lobziik mentioned this pull request Jul 8, 2021
Merged
@JoelSpeed
Copy link
Copy Markdown
Contributor

JoelSpeed commented Jul 9, 2021

/retest

@JoelSpeed
Copy link
Copy Markdown
Contributor

JoelSpeed commented Jul 9, 2021

@Danil-Grigorev PTAL, this is failing the verify step for some reason

@Danil-Grigorev Danil-Grigorev force-pushed the revendor-azure-library-go branch from 77010a7 to 2838a78 Compare July 9, 2021 13:07
@openshift-ci openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 9, 2021
@Danil-Grigorev Danil-Grigorev force-pushed the revendor-azure-library-go branch from 2838a78 to bffc5c6 Compare July 12, 2021 09:49
@openshift-ci openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 12, 2021
@Danil-Grigorev Danil-Grigorev force-pushed the revendor-azure-library-go branch 2 times, most recently from cc1b434 to 1768110 Compare July 12, 2021 10:50
@lobziik
Copy link
Copy Markdown
Contributor

lobziik commented Jul 12, 2021

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 12, 2021
@openshift-bot
Copy link
Copy Markdown

openshift-bot commented Jul 12, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Copy Markdown

openshift-bot commented Jul 12, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown

openshift-bot commented Jul 12, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown

openshift-bot commented Jul 12, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown

openshift-bot commented Jul 12, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown

openshift-bot commented Jul 12, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 6c0aa9c into openshift:master Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoelSpeed JoelSpeed JoelSpeed left review comments

@Fedosin Fedosin Awaiting requested review from Fedosin

@mandre mandre Awaiting requested review from mandre

@lobziik lobziik Awaiting requested review from lobziik

Assignees

@lobziik lobziik

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Danil-Grigorev @Fedosin @lobziik @JoelSpeed @openshift-bot @openshift-merge-robot