Skip to content

Extract cloud config sync controller to separate binary#86

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
lobziik:config-sync-separated
Jul 9, 2021
Merged

Extract cloud config sync controller to separate binary#86
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
lobziik:config-sync-separated

Conversation

@lobziik
Copy link
Copy Markdown
Contributor

@lobziik lobziik commented Jul 8, 2021

  • cloud config sync controller was extracted to separate binary
  • redundant rbac perms was removed
  • deployment manifest changes
  • 'verify' was removed from build make target

@openshift-ci openshift-ci Bot requested review from Fedosin and elmiko July 8, 2021 14:31
@lobziik
Copy link
Copy Markdown
Contributor Author

lobziik commented Jul 8, 2021

/retest

@lobziik lobziik mentioned this pull request Jul 8, 2021
Merged
JoelSpeed
JoelSpeed reviewed Jul 8, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@JoelSpeed JoelSpeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 8, 2021
Fedosin
Fedosin approved these changes Jul 8, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@Fedosin Fedosin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on OpenStack. Everything works as expected!

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2021
@Fedosin
Copy link
Copy Markdown
Contributor

Fedosin commented Jul 8, 2021

/test e2e-aws-ccm

elmiko
elmiko approved these changes Jul 8, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@elmiko elmiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me
/lgtm

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jul 8, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elmiko, Fedosin, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [Fedosin,JoelSpeed,elmiko]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Copy Markdown

openshift-bot commented Jul 8, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link
Copy Markdown

openshift-bot commented Jul 8, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown

openshift-bot commented Jul 8, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown

openshift-bot commented Jul 8, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown

openshift-bot commented Jul 8, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown

openshift-bot commented Jul 9, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown

openshift-bot commented Jul 9, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 35df5a9 into openshift:master Jul 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoelSpeed JoelSpeed JoelSpeed left review comments

+2 more reviewers

@elmiko elmiko elmiko approved these changes

@Fedosin Fedosin Fedosin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@elmiko elmiko

@Fedosin Fedosin

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@lobziik @Fedosin @openshift-bot @elmiko @JoelSpeed @openshift-merge-robot