Update the container init script to not use the legacy workaround#88
Conversation
| func checkContainerCommand(t *testing.T, podSpec corev1.PodSpec) { | ||
| binBash := "/bin/bash" | ||
| dashC := "-c" | ||
| // This script should be present on every node. |
There was a problem hiding this comment.
| // This script should be present on every node. | |
| // This script should be present on every master node. |
There was a problem hiding this comment.
I wonder if it matters that masters and workers will communicate with API Server using different load balancers. Should it be documented somewhere? That if worker is running CNM replica (Azure) then it is connected to a different endpoint? @JoelSpeed It is mostly an implementational detail, but still.
There was a problem hiding this comment.
We will need this to be every node for Azure, so we are fixing that on the MCO side already. This comment will be updated to reflect the changes and the differences once that is merged
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Danil-Grigorev The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
openshift-ci
Bot
added
the
needs-rebase
JoelSpeed
force-pushed
the
update-exec-script
branch
from
e528be8 to
b43eca5
Compare
openshift-ci
Bot
removed
the
needs-rebase
|
/lgtm |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/override ci/prow/e2e-aws-upgrade This PR serves no functional changes as we never observed the value we were setting here anyway, no real need for the upgrade to pass as this won't affect upgrades |
|
@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/e2e-aws-upgrade DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/override ci/prow/e2e-aws-upgrade We didn't ever handle this variable, shouldn't have any effect at all. |
|
@lobziik: Overrode contexts on behalf of lobziik: ci/prow/e2e-aws-upgrade DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
6 participants
This updates the init script that must be present on pods/containers to remove the legacy fallback. I've also added a note to the test that links to where the current solution was implemented in MCO. ie openshift/machine-config-operator#2232