Skip to content

Switch to go.mod#111

Closed
damemi wants to merge 8 commits intoopenshift:masterfrom
damemi:switch-to-go-mod
Closed

Switch to go.mod#111
damemi wants to merge 8 commits intoopenshift:masterfrom
damemi:switch-to-go-mod

Conversation

@damemi
Copy link
Copy Markdown
Contributor

@damemi damemi commented Jan 22, 2020

No description provided.

@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 22, 2020
@patrickdillon patrickdillon mentioned this pull request Jan 22, 2020
Closed
@patrickdillon
Copy link
Copy Markdown
Contributor

patrickdillon commented Jan 22, 2020

This bump includes API updates needed for VSphere deployments. Specifically to update Infra.Status.PlatformStatus.VSphere I used the release image created by CI to test a vsphere deployment and the cluster infrastructure object is created successfully.

/lgtm
cc @jcpowermac @sdodson

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 22, 2020
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jan 22, 2020

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: damemi, patrickdillon
To complete the pull request process, please assign mfojtik
You can assign the PR to them by writing /assign @mfojtik in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@damemi
Copy link
Copy Markdown
Contributor Author

damemi commented Jan 22, 2020

I think these terraform errors are known
/retest

@patrickdillon patrickdillon mentioned this pull request Jan 22, 2020
Merged
@patrickdillon
Copy link
Copy Markdown
Contributor

patrickdillon commented Jan 23, 2020

/test images
I need these for my personal testing.

@patrickdillon
Copy link
Copy Markdown
Contributor

patrickdillon commented Jan 23, 2020

/test images

@damemi
Copy link
Copy Markdown
Contributor Author

damemi commented Jan 23, 2020

/retest

2 similar comments
@damemi
Copy link
Copy Markdown
Contributor Author

damemi commented Jan 23, 2020

/retest

@damemi
Copy link
Copy Markdown
Contributor Author

damemi commented Jan 24, 2020

/retest

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jan 24, 2020

@damemi: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws df522fb link /test e2e-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jan 24, 2020

@damemi: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 24, 2020
@damemi
Copy link
Copy Markdown
Contributor Author

damemi commented Jan 29, 2020

This was superceded by #113
/close

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jan 29, 2020

@damemi: Closed this PR.

Details

In response to this:

This was superceded by #113
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@sttts sttts Awaiting requested review from sttts

Assignees

@patrickdillon patrickdillon

Labels

lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@damemi @patrickdillon @openshift-ci-robot