Skip to content

CNF-23046: Migrate away from deprecated ioutil#454

Open
sebrandon1 wants to merge 1 commit intoopenshift:mainfrom
sebrandon1:ioutil_deprecation
Open

CNF-23046: Migrate away from deprecated ioutil#454
sebrandon1 wants to merge 1 commit intoopenshift:mainfrom
sebrandon1:ioutil_deprecation

Conversation

@sebrandon1
Copy link
Copy Markdown
Member

@sebrandon1 sebrandon1 commented Nov 24, 2025

ioutil has been deprecated since Go 1.16: https://go.dev/doc/go1.16#ioutil

Tracking issue: redhat-best-practices-for-k8s/telco-bot#52

Summary by CodeRabbit

  • Chores
    • Modernized internal file I/O to remove deprecated APIs and align with current standard library usage, improving maintainability and long-term reliability without changing user-facing behavior.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Nov 24, 2025

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 90f06163-559d-428c-b4ac-d8a1cdbf351f

📥 Commits

Reviewing files that changed from the base of the PR and between 11b7f09 and fd07510.

📒 Files selected for processing (2)
  • pkg/cmd/render/render.go
  • pkg/operator/kube_cloud_config/bootstrap.go
✅ Files skipped from review due to trivial changes (2)
  • pkg/operator/kube_cloud_config/bootstrap.go
  • pkg/cmd/render/render.go

Walkthrough

Replaced deprecated ioutil.ReadFile/ioutil.WriteFile calls with os.ReadFile/os.WriteFile and removed io/ioutil imports. No functional changes to control flow, error handling, or exported declarations.

Changes

Cohort / File(s) Summary
I/O API modernization
pkg/cmd/render/render.go, pkg/operator/kube_cloud_config/bootstrap.go
Replaced ioutil.ReadFile/ioutil.WriteFile with os.ReadFile/os.WriteFile and removed io/ioutil imports. Error handling and control flow unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 12
✅ Passed checks (12 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly and clearly describes the main change: migrating away from deprecated ioutil package to use standard library equivalents.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The pull request only modifies production code files to migrate from deprecated ioutil to os functions. No test files are modified.
Test Structure And Quality ✅ Passed PR modifies only application source files with no Ginkgo test files added, modified, or removed, so test quality requirements are not applicable.
Microshift Test Compatibility ✅ Passed This check is not applicable to this pull request. The custom check specifically applies to when new Ginkgo e2e tests are added, but this PR contains no new tests whatsoever. The changes are purely in non-test utility files that update deprecated file I/O function calls from the ioutil package to their modern os package equivalents.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR only updates internal library code to migrate from deprecated io/ioutil functions to standard library equivalents; no new Ginkgo e2e tests are added.
Topology-Aware Scheduling Compatibility ✅ Passed PR contains only refactoring changes migrating deprecated ioutil operations to os equivalents with no impact on scheduling constraints, affinity rules, node selectors, replica counts, or topology-aware logic.
Ote Binary Stdout Contract ✅ Passed PR replaces deprecated ioutil functions with modern os equivalents in library utility functions without violating OTE Binary Stdout Contract.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed This pull request does not add any new Ginkgo e2e tests. The modified files contain no test declarations, Ginkgo imports, or test-related code, only utility/operational changes.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Review rate limit: 6/10 reviews remaining, refill in 23 minutes and 22 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Nov 24, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sebrandon1
Once this PR has been reviewed and has the lgtm label, please assign p0lyn0mial for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sebrandon1
Copy link
Copy Markdown
Member Author

/retest

@sebrandon1 sebrandon1 changed the title Migrate away from deprecated ioutil CNF-23046: Migrate away from deprecated ioutil Apr 20, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 20, 2026
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 20, 2026

@sebrandon1: This pull request references CNF-23046 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

ioutil has been deprecated since Go 1.16: https://go.dev/doc/go1.16#ioutil

Tracking issue: redhat-best-practices-for-k8s/telco-bot#52

Summary by CodeRabbit

  • Chores
  • Modernized internal code by updating file I/O operations to use current standard library APIs, removing usage of deprecated functions and improving codebase maintainability.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 30, 2026

@sebrandon1: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-serial-techpreview-2of2 fd07510 link true /test e2e-aws-serial-techpreview-2of2

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants