Generate operator/v1alpha1 CRDs, update for https://github.com/openshift/api/pull/384#73
Merged
openshift-merge-robot merged 2 commits intoopenshift:masterfrom Jul 23, 2019
Conversation
openshift-ci-robot
added
do-not-merge/work-in-progress
Contributor
mtrmac
force-pushed
the
icsp-explicit-source
branch
from
cf5aebd to
4e309a5
Compare
mtrmac
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Contributor
Author
|
Rebased on top of merged #70, PTAL. |
Contributor
Author
|
/retest |
3 similar comments
Contributor
Author
|
/retest |
Contributor
Author
|
/retest |
Contributor
Author
|
/retest |
Contributor
|
@sttts this is ready to be merged, PTAL. |
Contributor
|
@deads2k @abhinavdahiya PTAL |
Contributor
|
/lgtm |
Member
Contributor
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, mtrmac, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Contributor
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Member
|
/test e2e-aws |
Member
|
/test e2e-aws-upgrade |
Contributor
|
/retest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE: This includes UNMERGED #70, and will need to be rebased on top of it.This PR updates vendor openshift/api for openshift/api#384 , adds generation of the CRDs for the operator/v1alpha1 namespace (or was it omitted intentionally?) and runs the CRD generator.