Skip to content

WIP pkg/operator/hostetcdendpointcontroller: disable host-etcd update duing cluster bootstrap#60

Closed
hexfusion wants to merge 1 commit intoopenshift:masterfrom
hexfusion:host-etcd-bootstrap
Closed

WIP pkg/operator/hostetcdendpointcontroller: disable host-etcd update duing cluster bootstrap#60
hexfusion wants to merge 1 commit intoopenshift:masterfrom
hexfusion:host-etcd-bootstrap

Conversation

@hexfusion
Copy link
Copy Markdown
Contributor

@hexfusion hexfusion commented Jan 28, 2020 •
edited
Loading

Depends on openshift/installer#2998

Signed-off-by: Sam Batschelet sbatsche@redhat.com

@hexfusion
pkg/operator/hostetcdendpointcontroller: disable host-etcd update dur…
d63cc32 
…ing cluster bootstrap

Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 28, 2020
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jan 28, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hexfusion

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 28, 2020
@hexfusion hexfusion mentioned this pull request Jan 28, 2020
Closed
@hexfusion
Copy link
Copy Markdown
Contributor Author

hexfusion commented Jan 28, 2020

Since we are in a bit of a chicken and egg scenario I think the only path forward is to go Unmanaged merge the installer PR then go back to Managed and merge this PR.

@hexfusion
Copy link
Copy Markdown
Contributor Author

hexfusion commented Jan 28, 2020

/test e2e-gcp

1 similar comment
@hexfusion
Copy link
Copy Markdown
Contributor Author

hexfusion commented Jan 28, 2020

/test e2e-gcp

@hexfusion
Copy link
Copy Markdown
Contributor Author

hexfusion commented Jan 28, 2020 •
edited
Loading

retest for cycles

/test e2e-azure

@hexfusion
Copy link
Copy Markdown
Contributor Author

hexfusion commented Jan 28, 2020

flake

/test e2e-gcp-upgrade

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jan 28, 2020

@hexfusion: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-gcp-upgrade d63cc32 link /test e2e-gcp-upgrade
ci/prow/e2e-azure d63cc32 link /test e2e-azure

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 13, 2020
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Feb 13, 2020

@hexfusion: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@deads2k
Copy link
Copy Markdown
Contributor

deads2k commented Feb 13, 2020

superceded in master

@deads2k deads2k closed this Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mfojtik mfojtik Awaiting requested review from mfojtik

@soltysh soltysh Awaiting requested review from soltysh

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hexfusion @openshift-ci-robot @deads2k