Exits with a non-zero code in case Etcd backup fails by fsoppelsa · Pull Request #871 · openshift/cluster-etcd-operator

fsoppelsa · 2022-07-04T09:22:00Z

So cluster-backup.sh exits with non-zero and this return code is usable for monitoring purposes.

…eckable for monitoring purposes

tjungblu · 2022-07-04T11:22:11Z

@fsoppelsa thanks, I think you also need to run make update so it can make its way into the binary.

EmilyM1 · 2022-07-06T21:11:05Z

/test verify

EmilyM1 · 2022-07-06T21:13:41Z

There appears a difference in bin data. @tjungblu has a great suggestion and make verify may fix the test. Alternatively
make update-bindata may work too.

…ase of an error

fsoppelsa · 2022-07-13T14:45:58Z

I don't know if this is supposed to work as if I run make update the .go file gets modified and introduces a $? which I think will break the Go code... Can somebody please help and fix properly?

Elbehery · 2022-07-13T14:53:57Z

I don't know if this is supposed to work as if I run make update the .go file gets modified and introduces a $? which I think will break the Go code... Can somebody please help and fix properly?

hello ✋🏽 , can you run make verify from the root folder of the repo ? ..

If it does not complain, then we are fine,

Please keep me updated

fsoppelsa · 2022-07-13T14:59:33Z

I don't know if this is supposed to work as if I run make update the .go file gets modified and introduces a $? which I think will break the Go code... Can somebody please help and fix properly?

hello ✋🏽 , can you run make verify from the root folder of the repo ? ..

If it does not complain, then we are fine,

Please keep me updated

❯ make verify                                           cluster-etcd-operator -> check-snapshot-exitcode
make: realpath: Command not found
Running `gofmt -s -l` on 90 file(s).
go vet -mod=vendor ./...
ln -s /Users/fsoppelsa/go/src/github.com/openshift/cluster-etcd-operator/vendor "/var/folders/0b/45ybh15s0yg09psbg6mxztmr0000gn/T/tmp.xRnPkRIP/src"
export GO111MODULE=off && export GOPATH=/var/folders/0b/45ybh15s0yg09psbg6mxztmr0000gn/T/tmp.xRnPkRIP && export GOBIN=/var/folders/0b/45ybh15s0yg09psbg6mxztmr0000gn/T/tmp.xRnPkRIP/bin && go install "./vendor/github.com/go-bindata/go-bindata/..."
/var/folders/0b/45ybh15s0yg09psbg6mxztmr0000gn/T/tmp.xRnPkRIP/bin/go-bindata -nocompress -nometadata -prefix "bindata" -pkg "etcd_assets" -o "/var/folders/0b/45ybh15s0yg09psbg6mxztmr0000gn/T/tmp.pUbCGO2u/pkg/operator/etcd_assets/bindata.go" -ignore "OWNERS" ./bindata/etcd/... && gofmt -s -w "/var/folders/0b/45ybh15s0yg09psbg6mxztmr0000gn/T/tmp.pUbCGO2u/pkg/operator/etcd_assets/bindata.go" && diff -Naup {.,/var/folders/0b/45ybh15s0yg09psbg6mxztmr0000gn/T/tmp.pUbCGO2u}/pkg/operator/etcd_assets/bindata.go
❯ git commit -a -m "make verify"                      cluster-etcd-operator -> check-snapshot-exitcode ?
On branch check-snapshot-exitcode
Your branch is up to date with 'origin/check-snapshot-exitcode'.

Untracked files:
	_output/

nothing added to commit but untracked files present
1 ❯ git push                                          cluster-etcd-operator -> check-snapshot-exitcode ?
Everything up-to-date

Elbehery · 2022-07-13T15:37:22Z

I don't know if this is supposed to work as if I run make update the .go file gets modified and introduces a $? which I think will break the Go code... Can somebody please help and fix properly?

hello ✋🏽 , can you run make verify from the root folder of the repo ? ..
If it does not complain, then we are fine,
Please keep me updated

I don't know if this is supposed to work as if I run make update the .go file gets modified and introduces a $? which I think will break the Go code... Can somebody please help and fix properly?

hello ✋🏽 , can you run make verify from the root folder of the repo ? ..
If it does not complain, then we are fine,
Please keep me updated
❯ make verify                                           cluster-etcd-operator -> check-snapshot-exitcode
make: realpath: Command not found
Running `gofmt -s -l` on 90 file(s).
go vet -mod=vendor ./...
ln -s /Users/fsoppelsa/go/src/github.com/openshift/cluster-etcd-operator/vendor "/var/folders/0b/45ybh15s0yg09psbg6mxztmr0000gn/T/tmp.xRnPkRIP/src"
export GO111MODULE=off && export GOPATH=/var/folders/0b/45ybh15s0yg09psbg6mxztmr0000gn/T/tmp.xRnPkRIP && export GOBIN=/var/folders/0b/45ybh15s0yg09psbg6mxztmr0000gn/T/tmp.xRnPkRIP/bin && go install "./vendor/github.com/go-bindata/go-bindata/..."
/var/folders/0b/45ybh15s0yg09psbg6mxztmr0000gn/T/tmp.xRnPkRIP/bin/go-bindata -nocompress -nometadata -prefix "bindata" -pkg "etcd_assets" -o "/var/folders/0b/45ybh15s0yg09psbg6mxztmr0000gn/T/tmp.pUbCGO2u/pkg/operator/etcd_assets/bindata.go" -ignore "OWNERS" ./bindata/etcd/... && gofmt -s -w "/var/folders/0b/45ybh15s0yg09psbg6mxztmr0000gn/T/tmp.pUbCGO2u/pkg/operator/etcd_assets/bindata.go" && diff -Naup {.,/var/folders/0b/45ybh15s0yg09psbg6mxztmr0000gn/T/tmp.pUbCGO2u}/pkg/operator/etcd_assets/bindata.go
❯ git commit -a -m "make verify"                      cluster-etcd-operator -> check-snapshot-exitcode ?
On branch check-snapshot-exitcode
Your branch is up to date with 'origin/check-snapshot-exitcode'.

Untracked files:
	_output/

nothing added to commit but untracked files present
1 ❯ git push                                          cluster-etcd-operator -> check-snapshot-exitcode ?
Everything up-to-date

That looks fine, where is the mistake that could break the code you were referring to ?

fsoppelsa · 2022-07-13T15:41:27Z

That looks fine, where is the mistake that could break the code you were referring to ?

This file pkg/operator/etcd_assets/bindata.go but I think it's a big comment:

https://github.com/openshift/cluster-etcd-operator/pull/871/files#diff-3c9acfec0f6df771b5bfe6d2173353a59b755eb7ac1b9c2e2c88bef5e1760c41

Elbehery · 2022-07-13T15:59:17Z

That looks fine, where is the mistake that could break the code you were referring to ?

This file pkg/operator/etcd_assets/bindata.go but I think it's a big comment:

https://github.com/openshift/cluster-etcd-operator/pull/871/files#diff-3c9acfec0f6df771b5bfe6d2173353a59b755eb7ac1b9c2e2c88bef5e1760c41

I reviewed the changes character by character, and I could not find a mistake .. So what you have done is right, you edit bindata and then running make update && make verify to update the manifest

Elbehery · 2022-07-14T16:21:36Z

/retest-required

tjungblu · 2022-07-18T12:30:26Z

/retest-required

Elbehery · 2022-07-18T14:58:48Z

/lgtm

Elbehery · 2022-07-19T13:43:09Z

/assign @dusk125

dusk125 · 2022-07-19T14:13:55Z

/approve

openshift-ci · 2022-07-19T14:14:30Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dusk125, Elbehery, fsoppelsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [dusk125]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2022-07-19T17:26:15Z

/retest-required

Remaining retests: 2 against base HEAD 1a08e26 and 8 for PR HEAD c9540ed in total

tjungblu · 2022-07-20T15:44:43Z

/retest-required

openshift-ci-robot · 2022-07-20T17:37:03Z

/retest-required

Remaining retests: 1 against base HEAD 1a08e26 and 7 for PR HEAD c9540ed in total

openshift-ci-robot · 2022-07-20T20:37:00Z

/retest-required

Remaining retests: 0 against base HEAD 1a08e26 and 6 for PR HEAD c9540ed in total

Elbehery · 2022-07-21T11:46:36Z

/retest-required

openshift-ci-robot · 2022-07-22T04:51:06Z

/retest-required

Remaining retests: 2 against base HEAD c6db403 and 5 for PR HEAD c9540ed in total

fsoppelsa · 2022-07-22T07:48:41Z

/retest

openshift-ci-robot · 2022-07-22T10:51:13Z

/retest-required

Remaining retests: 1 against base HEAD c6db403 and 4 for PR HEAD c9540ed in total

openshift-ci-robot · 2022-07-22T13:51:11Z

/retest-required

Remaining retests: 0 against base HEAD c6db403 and 3 for PR HEAD c9540ed in total

Elbehery · 2022-07-27T14:11:15Z

/retest-required

fsoppelsa · 2022-07-29T08:16:05Z

@Elbehery so apparently tests are failing on ci/prow/e2e-aws-single-node , why? 🤔 Is there anything wrong in this (tiny) commit that breaks aws-sno?

tjungblu · 2022-07-29T08:39:27Z

/retest-required

SNO is flaky for us for a while, but it's sometimes OVN, today it's network edge.

tjungblu · 2022-07-29T08:40:21Z

if that's not coming through today, I'd ask @dusk125 to override the test today. It's clearly not related to your script.

dusk125 · 2022-07-29T19:15:13Z

Moving this forward since the failure is unrelated to etcd
/override ci/prow/e2e-aws-single-node

openshift-ci · 2022-07-29T19:15:49Z

@dusk125: Overrode contexts on behalf of dusk125: ci/prow/e2e-aws-single-node

Details

In response to this:

Moving this forward since the failure is unrelated to etcd
/override ci/prow/e2e-aws-single-node

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2022-07-30T02:53:06Z

@fsoppelsa: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

tjungblu · 2022-08-02T10:40:31Z

/cherry-pick release-4.11

openshift-cherrypick-robot · 2022-08-02T10:41:14Z

@tjungblu: new pull request created: #903

Details

In response to this:

/cherry-pick release-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Exits with a non-zero error in case Etcd backup fails, so it'll be ch…

b3a9f5a

…eckable for monitoring purposes

openshift-ci Bot requested review from EmilyM1 and hasbro17 July 4, 2022 09:22

stlaz reviewed Jul 7, 2022

View reviewed changes

Comment thread bindata/etcd/etcd-common-tools Outdated

fsoppelsa added 2 commits July 13, 2022 16:43

check where this is called and exit with a non-zero status there in c…

a2a3aca

…ase of an error

fixes a mistake where I deleted a return 1

c9540ed

openshift-ci Bot assigned Elbehery Jul 18, 2022

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 18, 2022

openshift-ci Bot assigned dusk125 Jul 19, 2022

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 19, 2022

openshift-merge-robot merged commit 2272cc7 into openshift:master Jul 30, 2022

openshift-cherrypick-robot mentioned this pull request Aug 2, 2022

Bug 2113927: [release-4.11] Exits with a non-zero code in case Etcd backup fails #903

Merged

Conversation

fsoppelsa commented Jul 4, 2022

Uh oh!

tjungblu commented Jul 4, 2022

Uh oh!

EmilyM1 commented Jul 6, 2022

Uh oh!

EmilyM1 commented Jul 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

fsoppelsa commented Jul 13, 2022

Uh oh!

Elbehery commented Jul 13, 2022

Uh oh!

fsoppelsa commented Jul 13, 2022

Uh oh!

Elbehery commented Jul 13, 2022

Uh oh!

fsoppelsa commented Jul 13, 2022

Uh oh!

Elbehery commented Jul 13, 2022

Uh oh!

Elbehery commented Jul 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tjungblu commented Jul 18, 2022

Uh oh!

Elbehery commented Jul 18, 2022

Uh oh!

Elbehery commented Jul 19, 2022

Uh oh!

dusk125 commented Jul 19, 2022

Uh oh!

openshift-ci Bot commented Jul 19, 2022

Uh oh!

openshift-ci-robot commented Jul 19, 2022

Uh oh!

tjungblu commented Jul 20, 2022

Uh oh!

openshift-ci-robot commented Jul 20, 2022

Uh oh!

openshift-ci-robot commented Jul 20, 2022

Uh oh!

Elbehery commented Jul 21, 2022

Uh oh!

openshift-ci-robot commented Jul 22, 2022

Uh oh!

fsoppelsa commented Jul 22, 2022

Uh oh!

openshift-ci-robot commented Jul 22, 2022

Uh oh!

openshift-ci-robot commented Jul 22, 2022

Uh oh!

Elbehery commented Jul 27, 2022

Uh oh!

fsoppelsa commented Jul 29, 2022

Uh oh!

tjungblu commented Jul 29, 2022

Uh oh!

tjungblu commented Jul 29, 2022

Uh oh!

dusk125 commented Jul 29, 2022

Uh oh!

openshift-ci Bot commented Jul 29, 2022

Uh oh!

openshift-ci Bot commented Jul 30, 2022

Uh oh!

tjungblu commented Aug 2, 2022

Uh oh!

openshift-cherrypick-robot commented Aug 2, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

EmilyM1 commented Jul 6, 2022 •

edited

Loading

Elbehery commented Jul 14, 2022 •

edited

Loading