Add the metal3-state host to NoProxy#1106
Add the metal3-state host to NoProxy#1106derekhiggins wants to merge 1 commit intoopenshift:masterfrom
Conversation
When using the Baremetal platform type data downloaded from metal3-state is internal.
|
/hold |
openshift-ci
Bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: derekhiggins The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Unless something has changed, you'll need an installer PR and they need to land roughly at the same time to avoid a breakage. The proxy is created two places and needs to match. Some additional info in openshift/installer#2939 |
| // "metadata.google.internal." added due to https://bugzilla.redhat.com/show_bug.cgi?id=1754049 | ||
| set.Insert("metadata", "metadata.google.internal", "metadata.google.internal.") | ||
| case configv1.BareMetalPlatformType: | ||
| set.Insert("metal3-state.openshift-machine-api") |
There was a problem hiding this comment.
I'd suggest adding a comment here saying this is managed by cluster-baremetal-operator, so people know why it's here (and where it's coming from)
|
@derekhiggins: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Posted an alternative solution to openshift/cluster-baremetal-operator#147 |
|
openshift/cluster-baremetal-operator#147 merged /close |
|
@stbenjam: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
2 participants
When using the Baremetal platform type data
downloaded from metal3-state is internal.
Fixes: #1105