Remove references to the hosts kubeconfig by kyrtapz · Pull Request #1612 · openshift/cluster-network-operator

kyrtapz · 2022-11-03T16:54:48Z

Since #976 we are no longer using the hosts kubeconfig.

Remove the references to the old approach.

This addresses https://bugzilla.redhat.com/show_bug.cgi?id=2083334, security bugs do not work with the bot:

When the change merges, the Bugzilla associated with the CVE must be set to MODIFIED. Since the DPTP bugzilla bot is not permitted to scan bugs with the SECURITY group in Bugzilla, The REP will not be able to use the bot's public functionality of moving their bug to MODIFIED.
https://docs.google.com/document/d/1KuenDafC3Ukw19jY55tkVeH8nNVVAi8TEAfqynoVfzY/edit#heading=h.ikdk6suc575k

Signed-off-by: Patryk Diak pdiak@redhat.com

openshift-ci · 2022-11-03T16:58:12Z

@kyrtapz: This pull request references Bugzilla bug 1895030, which is invalid:

expected the bug to target the "4.12.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1895030: Remove references to the hosts kubeconfig

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kyrtapz · 2022-11-03T16:59:29Z

/bugzilla refresh

openshift-ci · 2022-11-03T16:59:33Z

@kyrtapz: This pull request references Bugzilla bug 1895030, which is invalid:

expected the bug to target the "4.12.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kyrtapz · 2022-11-03T17:00:11Z

/bugzilla refresh

openshift-ci · 2022-11-03T17:00:14Z

@kyrtapz: Bugzilla bug 2083334 is in a bug group that is not in the allowed groups for this repo.
Allowed groups for this repo are:

nec
qe_staff
redhat

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kyrtapz · 2022-11-03T17:16:30Z

/bugzilla refresh

openshift-ci · 2022-11-03T17:16:32Z

@kyrtapz: Bugzilla bug 2083334 is in a bug group that is not in the allowed groups for this repo.
Allowed groups for this repo are:

nec
qe_staff
redhat

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kyrtapz · 2022-11-04T08:58:45Z

/retest

openshift-ci · 2022-11-04T10:30:25Z

@kyrtapz: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

Remove references to the hosts kubeconfig

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kyrtapz · 2022-11-08T08:49:04Z

/retest

kyrtapz · 2022-11-08T14:37:43Z

/retest

Signed-off-by: Patryk Diak <pdiak@redhat.com>

jcaamano · 2022-11-10T12:02:57Z

@kyrtapz wanted to check with you a couple of things:

no potential downgrade issue here, since probably the environment file has been available since a few versions already.
could you check with @zshi-redhat if microshift depends on any of this?

kyrtapz · 2022-11-10T13:54:45Z

1. no potential downgrade issue here, since probably the environment file has been available since a few versions already.

There should be no downgrade issues, /etc/kubernetes/apiserver-url.env is available since 4.7 and we stopped reading the kubeconfig here: #976
https://bugzilla.redhat.com/show_bug.cgi?id=2083334#c1

2. could you check with @zshi-redhat if microshift depends on any of this?

From what I understand CNO is not run in microshift so this should not affect it at all(Thanks @pmtk!)
@zshi-redhat please help us confirm that there is no indirect impact on microshift.

jcaamano · 2022-11-10T14:43:00Z

After talking with @zshi-redhat, this is a non issue for microshift.

jcaamano · 2022-11-10T15:02:16Z

/lgtm
/approve

openshift-ci · 2022-11-10T15:03:07Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcaamano, kyrtapz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [jcaamano]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

kyrtapz · 2022-11-10T15:04:14Z

/cherry-pick release-4.12

openshift-cherrypick-robot · 2022-11-10T15:04:16Z

@kyrtapz: once the present PR merges, I will cherry-pick it on top of release-4.12 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2022-11-10T17:59:04Z

@kyrtapz: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-vsphere-ovn	`14ac289`	link	false	`/test e2e-vsphere-ovn`
ci/prow/e2e-network-mtu-migration-ovn-ipv6	`14ac289`	link	false	`/test e2e-network-mtu-migration-ovn-ipv6`
ci/prow/e2e-network-mtu-migration-ovn-ipv4	`14ac289`	link	false	`/test e2e-network-mtu-migration-ovn-ipv4`
ci/prow/e2e-aws-ovn-serial	`14ac289`	link	false	`/test e2e-aws-ovn-serial`
ci/prow/e2e-ovn-hybrid-step-registry	`14ac289`	link	false	`/test e2e-ovn-hybrid-step-registry`
ci/prow/e2e-openstack-sdn	`14ac289`	link	false	`/test e2e-openstack-sdn`
ci/prow/e2e-network-mtu-migration-sdn-ipv4	`14ac289`	link	false	`/test e2e-network-mtu-migration-sdn-ipv4`
ci/prow/e2e-openstack-ovn	`14ac289`	link	false	`/test e2e-openstack-ovn`
ci/prow/e2e-aws-sdn-upgrade	`14ac289`	link	false	`/test e2e-aws-sdn-upgrade`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

kyrtapz · 2022-11-21T09:03:35Z

/retest-required

openshift-cherrypick-robot · 2022-11-21T14:10:33Z

@kyrtapz: new pull request created: #1632

Details

In response to this:

/cherry-pick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci Bot requested review from jcaamano and trozet November 3, 2022 16:55

kyrtapz changed the title ~~OCPBUGSM-44162: Remove references to the hosts kubeconfig~~ Bug 1895030: Remove references to the hosts kubeconfig Nov 3, 2022

openshift-ci Bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Nov 3, 2022

kyrtapz changed the title ~~Bug 1895030: Remove references to the hosts kubeconfig~~ Bug 2083334: Remove references to the hosts kubeconfig Nov 3, 2022

kyrtapz changed the title ~~Bug 2083334: Remove references to the hosts kubeconfig~~ Remove references to the hosts kubeconfig Nov 4, 2022

openshift-ci Bot removed bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Nov 4, 2022

jcaamano suggested changes Nov 8, 2022

View reviewed changes

Comment thread cmd/cluster-network-operator/main.go Outdated

Remove references to the hosts kubeconfig

14ac289

Signed-off-by: Patryk Diak <pdiak@redhat.com>

kyrtapz force-pushed the remove_kubeconfig_usage branch from df1e5d2 to 14ac289 Compare November 9, 2022 11:54

openshift-ci Bot assigned jcaamano Nov 10, 2022

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Nov 10, 2022

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 10, 2022

openshift-merge-robot merged commit 47255bf into openshift:master Nov 21, 2022

openshift-cherrypick-robot mentioned this pull request Nov 21, 2022

[release-4.12] OCPBUGS-3944: Remove references to the hosts kubeconfig #1632

Merged

Conversation

kyrtapz commented Nov 3, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci Bot commented Nov 3, 2022

Uh oh!

kyrtapz commented Nov 3, 2022

Uh oh!

openshift-ci Bot commented Nov 3, 2022

Uh oh!

kyrtapz commented Nov 3, 2022

Uh oh!

openshift-ci Bot commented Nov 3, 2022

Uh oh!

kyrtapz commented Nov 3, 2022

Uh oh!

openshift-ci Bot commented Nov 3, 2022

Uh oh!

kyrtapz commented Nov 4, 2022

Uh oh!

openshift-ci Bot commented Nov 4, 2022

Uh oh!

kyrtapz commented Nov 8, 2022

Uh oh!

kyrtapz commented Nov 8, 2022

Uh oh!

Uh oh!

jcaamano commented Nov 10, 2022

Uh oh!

kyrtapz commented Nov 10, 2022

Uh oh!

jcaamano commented Nov 10, 2022

Uh oh!

jcaamano commented Nov 10, 2022

Uh oh!

openshift-ci Bot commented Nov 10, 2022

Uh oh!

kyrtapz commented Nov 10, 2022

Uh oh!

openshift-cherrypick-robot commented Nov 10, 2022

Uh oh!

openshift-ci Bot commented Nov 10, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kyrtapz commented Nov 21, 2022

Uh oh!

openshift-cherrypick-robot commented Nov 21, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

kyrtapz commented Nov 3, 2022 •

edited

Loading

openshift-ci Bot commented Nov 10, 2022 •

edited

Loading