Skip to content

[release-4.14] OCPBUGS-19748: Fix config status MTU migration not being updated#2034

Merged
openshift-merge-robot merged 1 commit intoopenshift:release-4.14from
openshift-cherrypick-robot:cherry-pick-2021-to-release-4.14
Sep 27, 2023
Merged

[release-4.14] OCPBUGS-19748: Fix config status MTU migration not being updated#2034
openshift-merge-robot merged 1 commit intoopenshift:release-4.14from
openshift-cherrypick-robot:cherry-pick-2021-to-release-4.14

Conversation

@openshift-cherrypick-robot
Copy link
Copy Markdown

@openshift-cherrypick-robot openshift-cherrypick-robot commented Sep 26, 2023

This is an automated cherry-pick of #2021

/assign jcaamano

@jcaamano
Fix config status MTU migration not being updated
9793e68 
Render has side effects in the passed in operConfig that are reflected
later on in the status when it is being updated. This stopped working
when the the passed in operConfig was changed to a copy that was not
then used when applying the status.

It makes sense to use the updated operConfig for everything that comes
after, not just Render, so change that to fix the issue.

Fixes: openshift#1952

Signed-off-by: Jaime Caamaño Ruiz <jcaamano@redhat.com>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 26, 2023
Merged
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Sep 26, 2023

@openshift-cherrypick-robot: Jira Issue OCPBUGS-18396 has been cloned as Jira Issue OCPBUGS-19748. Will retitle bug to link to clone.
/retitle [release-4.14] OCPBUGS-19748: Fix config status MTU migration not being updated

Details

In response to this:

This is an automated cherry-pick of #2021

/assign jcaamano

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot changed the title [release-4.14] OCPBUGS-18396: Fix config status MTU migration not being updated [release-4.14] OCPBUGS-19748: Fix config status MTU migration not being updated Sep 26, 2023
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Sep 26, 2023
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Sep 26, 2023

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-19748, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-18396 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-18396 targets the "4.15.0" version, which is one of the valid target versions: 4.15.0
  • bug has dependents

Requesting review from QA contact:
/cc @anuragthehatter

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #2021

/assign jcaamano

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jcaamano
Copy link
Copy Markdown
Contributor

jcaamano commented Sep 26, 2023

/test e2e-openstack-kuryr

@kyrtapz
Copy link
Copy Markdown
Contributor

kyrtapz commented Sep 26, 2023

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 26, 2023
@jcaamano
Copy link
Copy Markdown
Contributor

jcaamano commented Sep 26, 2023

/retest

@jcaamano
Copy link
Copy Markdown
Contributor

jcaamano commented Sep 26, 2023

/test e2e-network-mtu-migration-ovn-ipv6

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 26, 2023

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-vsphere-ovn 9793e68 link false /test e2e-vsphere-ovn
ci/prow/e2e-openstack-kuryr 9793e68 link false /test e2e-openstack-kuryr
ci/prow/e2e-vsphere-ovn-dualstack 9793e68 link false /test e2e-vsphere-ovn-dualstack

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@trozet
Copy link
Copy Markdown
Contributor

trozet commented Sep 26, 2023

/lgtm
/label backport-risk-assessed

@openshift-ci openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Sep 26, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kyrtapz, openshift-cherrypick-robot, trozet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 26, 2023
@huiran0826
Copy link
Copy Markdown

huiran0826 commented Sep 27, 2023

/label cherry-pick-approved

@openshift-ci openshift-ci Bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Sep 27, 2023
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Sep 27, 2023

/retest-required

Remaining retests: 0 against base HEAD c4c9572 and 2 for PR HEAD 9793e68 in total

@openshift-merge-robot openshift-merge-robot merged commit 603f963 into openshift:release-4.14 Sep 27, 2023
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Sep 27, 2023

@openshift-cherrypick-robot: Jira Issue OCPBUGS-19748: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-19748 has been moved to the MODIFIED state.

Details

In response to this:

This is an automated cherry-pick of #2021

/assign jcaamano

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot
Copy link
Copy Markdown
Contributor

openshift-merge-robot commented Sep 30, 2023

Fix included in accepted release 4.14.0-0.nightly-2023-09-29-231104

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anuragthehatter anuragthehatter Awaiting requested review from anuragthehatter

@abhat abhat Awaiting requested review from abhat

@JacobTanenbaum JacobTanenbaum Awaiting requested review from JacobTanenbaum

Assignees

@mffiedler mffiedler

@rbbratta rbbratta

@eurijon eurijon

@jcaamano jcaamano

@kyrtapz kyrtapz

@anuragthehatter anuragthehatter

@huiran0826 huiran0826

@asood-rh asood-rh

@jechen0648 jechen0648

@qiowang721 qiowang721

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.