Skip to content

Adds Support for Proxy CA Injection#282

Closed
danehans wants to merge 1 commit intoopenshift:masterfrom
danehans:op_ca_munt
Closed

Adds Support for Proxy CA Injection#282
danehans wants to merge 1 commit intoopenshift:masterfrom
danehans:op_ca_munt

Conversation

@danehans
Copy link
Copy Markdown
Contributor

@danehans danehans commented Aug 9, 2019

Adds opt-in support to cluster-network-operator for proxy ca injection.

Requires #274

/assign @squeed @bparees

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: danehans
To complete the pull request process, please assign squeed
You can assign the PR to them by writing /assign @squeed in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 9, 2019
@danehans
Copy link
Copy Markdown
Contributor Author

danehans commented Aug 9, 2019

This may not be needed since #277 uses static proxy settings for readiness probe instead of using env vars.

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 9, 2019
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@danehans: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws e8026ab link /test e2e-aws
ci/prow/e2e-aws-upgrade e8026ab link /test e2e-aws-upgrade

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@danehans
Copy link
Copy Markdown
Contributor Author

danehans commented Aug 9, 2019

Closing b/c we don't believe CNO needs to consume proxy.

@danehans danehans closed this Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants