[WIP] Start host openvswitch using systemctl by mccv1r0 · Pull Request #477 · openshift/cluster-network-operator

mccv1r0 · 2020-02-14T23:29:27Z

Start host openvswitch using systemctl

Signed-off-by: Michael Cambria mcambria@redhat.com

openshift-ci-robot · 2020-02-14T23:29:41Z

Hi @mccv1r0. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dcbw · 2020-02-15T19:48:17Z

/ok-to-test

dcbw · 2020-02-15T21:15:10Z

/retest

mccv1r0 · 2020-02-16T20:19:35Z

/retest

dcbw · 2020-02-17T15:36:06Z

/retest

mccv1r0 · 2020-02-17T18:39:05Z

/test e2e-gcp-ovn

mccv1r0 · 2020-03-02T21:04:03Z

/retest

mccv1r0 · 2020-03-20T20:07:19Z

/test e2e-gcp-ovn

mccv1r0 · 2020-03-24T20:01:41Z

/test e2e-gcp-ovn

rbbratta · 2020-05-05T13:39:51Z

          #!/bin/bash
          set -euo pipefail
+          set -x
+          if [[ -f /usr/bin/id ]]; then


-x for executable?

I don't understand all these checks, they are not atomic and thus worse than redundant because they hid the real error message.

/usr/bin/id openvswitch || true

or no || true with the set -e

or I guess it's not clear in which environment id is not present?

I don't understand all these checks, they are not atomic and thus worse than redundant because they hid the real error message.

Most (if not all) of these checks were added to debug and will not exist in the final PR.

rbbratta · 2020-05-05T13:40:51Z

+            echo "id command not found"
+          fi
+          if [[ -d /run/openvswitch ]]; then
+            ls -al /run/openvswitch


ls -al /run/openvswitch/ || true trailing / forces treating it as a directory.

I guess question here as well, when is /var/run not a symlink to /run ?

rbbratta · 2020-05-05T13:41:13Z

+          if [[ -d /var/run/openvswitch ]]; then
+            ls -al /var/run/openvswitch
+          fi
+          if [[ -f /var/run/openvswitch/ovs-vswitchd.pid ]] ; then


-r for readable.

openshift-ci-robot · 2020-05-15T18:57:27Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mccv1r0
To complete the pull request process, please assign dcbw
You can assign the PR to them by writing /assign @dcbw in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

cgwalters · 2020-05-29T17:34:50Z

xref https://bugzilla.redhat.com/show_bug.cgi?id=1839065

sinnykumari · 2020-06-15T13:13:33Z

can we get this PR rebased, wanted to test this with openshift/machine-config-operator#1636?

runcom · 2020-06-16T09:11:11Z

@sinnykumari I think this is rebased now but not sure about all these failures in CI

squeed · 2020-06-16T09:28:03Z

+            journalctl -xeu openvswitch --no-pager
+          else
+            echo "OVS started by ovs-node container, NOT RHCOS"
+          # Need container up v0.0 just to see if host starts ovs and friends


Can you fix the indentation here?

squeed · 2020-06-16T09:34:18Z

+          if (systemctl is-active --quiet openvswitch) ; then
+            echo "OVS started by RHCOS"
+            systemctl is-active openvswitch
+            journalctl -xeu openvswitch --no-pager


Probably just want to exec journalctl -f -u openvswitch ovsdb-server and be done with the script.

sinnykumari · 2020-06-16T09:36:24Z

@sinnykumari I think this is rebased now but not sure about all these failures in CI

Can it because we would need openshift/machine-config-operator#1636 merged first so that ovn related services are enabled on host to keep cluster install progressing further?

squeed · 2020-06-16T09:58:48Z

+          if [[ -f /var/run/openvswitch/ovsdb-server.pid ]] ; then
+            cat /var/run/openvswitch/ovsdb-server.pid
+          fi
          function quit {


Yikes. This needs to be moved to the "non-systemd case"

This is all debug code

not the kill -9...

Signed-off-by: Michael Cambria <mcambria@redhat.com>

trozet · 2020-06-17T17:22:21Z

+            journalctl -xeu openvswitch --no-pager
+          else
+            echo "OVS started by ovs-node container, NOT RHCOS"
+          # Need container up v0.0 just to see if host starts ovs and friends


I don't really understand why we need to start OVS from this container. Shouldn't systemd OVS be configured as a service with restart=Always? Why does a pod need to start it?

This might have been left-over from before the MCO was going to start OVS. Our first pass was starting system OVS from a pod via systemctl without MCO, but we moved to MCO because Clayton told us to.

openshift-ci-robot · 2020-10-12T15:46:53Z

@mccv1r0: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-aws-ovn	`32531fa`	link	`/test e2e-aws-ovn`
ci/prow/e2e-aws-sdn-multi	`7895421`	link	`/test e2e-aws-sdn-multi`
ci/prow/e2e-windows-hybrid-network	`7895421`	link	`/test e2e-windows-hybrid-network`
ci/prow/e2e-gcp-ovn	`7895421`	link	`/test e2e-gcp-ovn`
ci/prow/e2e-ovn-step-registry	`7895421`	link	`/test e2e-ovn-step-registry`
ci/prow/e2e-ovn-hybrid-step-registry	`7895421`	link	`/test e2e-ovn-hybrid-step-registry`
ci/prow/e2e-vsphere	`7895421`	link	`/test e2e-vsphere`
ci/prow/e2e-metal-ipi	`7895421`	link	`/test e2e-metal-ipi`
ci/prow/e2e-upgrade	`7895421`	link	`/test e2e-upgrade`
ci/prow/e2e-metal-ipi-ovn-ipv6	`7895421`	link	`/test e2e-metal-ipi-ovn-ipv6`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-merge-robot · 2020-10-15T16:47:21Z

@mccv1r0: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-aws-ovn-windows	`7895421`	link	`/test e2e-aws-ovn-windows`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 14, 2020

openshift-ci-robot requested review from rcarrillocruz and squeed February 14, 2020 23:30

openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 15, 2020

mccv1r0 force-pushed the sdn-702 branch from da961ec to 1202c67 Compare February 24, 2020 16:37

openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 24, 2020

mccv1r0 force-pushed the sdn-702 branch from 1202c67 to 181ae67 Compare March 18, 2020 21:20

mccv1r0 force-pushed the sdn-702 branch 4 times, most recently from 831d382 to 6c80243 Compare March 24, 2020 18:48

mccv1r0 force-pushed the sdn-702 branch 4 times, most recently from db927b0 to f1ecb44 Compare March 27, 2020 18:10

openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 27, 2020

mccv1r0 force-pushed the sdn-702 branch from f1ecb44 to 124b56f Compare March 27, 2020 18:21

openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 27, 2020

mccv1r0 force-pushed the sdn-702 branch 12 times, most recently from a6c4a86 to 61a4b6a Compare April 20, 2020 23:24

rbbratta reviewed May 5, 2020

View reviewed changes

Comment thread bindata/network/ovn-kubernetes/006-ovs-node.yaml

sinnykumari mentioned this pull request May 20, 2020

Start openvswitch and ovsdb-server when network is ovn/ovs openshift/machine-config-operator#1636

Merged

squeed reviewed Jun 16, 2020

View reviewed changes

mccv1r0 added 2 commits June 16, 2020 10:20

Add hostPath type: Directory where needed for OVS host directories

5a78f9d

Signed-off-by: Michael Cambria <mcambria@redhat.com>

ovnkube-master.yaml /run/openvswitch change from emptyDir to hostPath

7895421

Signed-off-by: Michael Cambria <mcambria@redhat.com>

trozet reviewed Jun 17, 2020

View reviewed changes

Conversation

mccv1r0 commented Feb 14, 2020

Uh oh!

openshift-ci-robot commented Feb 14, 2020

Uh oh!

dcbw commented Feb 15, 2020

Uh oh!

dcbw commented Feb 15, 2020

Uh oh!

mccv1r0 commented Feb 16, 2020

Uh oh!

dcbw commented Feb 17, 2020

Uh oh!

mccv1r0 commented Feb 17, 2020

Uh oh!

mccv1r0 commented Mar 2, 2020

Uh oh!

mccv1r0 commented Mar 20, 2020

Uh oh!

mccv1r0 commented Mar 24, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

openshift-ci-robot commented May 15, 2020

Uh oh!

cgwalters commented May 29, 2020

Uh oh!

sinnykumari commented Jun 15, 2020

Uh oh!

runcom commented Jun 16, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

squeed Jun 16, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sinnykumari commented Jun 16, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

openshift-ci-robot commented Oct 12, 2020

Uh oh!

openshift-merge-robot commented Oct 15, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

squeed Jun 16, 2020 •

edited

Loading