Skip to content

WIP Bug 1834852: Add make target to run operator with telepresence #155

Closed
marun wants to merge 2 commits intoopenshift:masterfrom
marun:telepresence
Closed

WIP Bug 1834852: Add make target to run operator with telepresence #155
marun wants to merge 2 commits intoopenshift:masterfrom
marun:telepresence

Conversation

@marun
Copy link
Copy Markdown
Contributor

@marun marun commented Apr 24, 2020

Once telepresence has been installed (see the run-telepresence.sh script for instructions), make telepresence will replace the operator's pod with a local process that has access to the same environment as the pod. This can speed up development since iteration doesn't rely on image build/push/pull. See https://telepresence.io for more details.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 24, 2020
@marun
Copy link
Copy Markdown
Contributor Author

marun commented Apr 24, 2020

This is not quite ready. Running the operator under telepresence results in a permission error:

I0423 19:03:46.962551 1802632 cmd.go:195] Using service-serving-cert provided certificates
I0423 19:03:47.113764 1802632 observer_polling.go:74] Adding reactor for file "/var/run/secrets/serving-cert/tls.crt"
panic: unexpected error while adding reactor for []string{"/var/run/secrets/serving-cert/tls.crt", "/var/run/secrets/serving-cert/tls.key", "/var/run/configmaps/config/config.yaml"}: open /var/run/secrets/serving-cert/tls.crt: permission denied

goroutine 1 [running]:
github.com/openshift/library-go/pkg/controller/fileobserver.(*pollingObserver).AddReactor(0xc0002b0000, 0xc000722000, 0xc000870420, 0xc000886040, 0x3, 0x4, 0x0, 0x0)
        /home/maru/go/pkg/mod/github.com/openshift/library-go@v0.0.0-20200407164846-05357b77e21e/pkg/controller/fileobserver/observer_polling.go:77 +0x9fb
github.com/openshift/library-go/pkg/controller/controllercmd.(*ControllerBuilder).WithRestartOnChange(0xc0004d2000, 0xc000216540, 0xc000870420, 0xc000886040, 0x3, 0x4, 0x0)
        /home/maru/go/pkg/mod/github.com/openshift/library-go@v0.0.0-20200407164846-05357b77e21e/pkg/controller/controllercmd/builder.go:117 +0xeb
github.com/openshift/library-go/pkg/controller/controllercmd.(*ControllerCommandConfig).StartController(0xc000782480, 0x244c200, 0xc000800ec0, 0xc000800ec0, 0xc000826850)
        /home/maru/go/pkg/mod/github.com/openshift/library-go@v0.0.0-20200407164846-05357b77e21e/pkg/controller/controllercmd/cmd.go:269 +0x386
github.com/openshift/library-go/pkg/controller/controllercmd.(*ControllerCommandConfig).NewCommandWithContext.func1(0xc000127400, 0xc000819920, 0x0, 0x2)
        /home/maru/go/pkg/mod/github.com/openshift/library-go@v0.0.0-20200407164846-05357b77e21e/pkg/controller/controllercmd/cmd.go:123 +0x67a
github.com/spf13/cobra.(*Command).execute(0xc000127400, 0xc0008198e0, 0x2, 0x2, 0xc000127400, 0xc0008198e0)
        /home/maru/go/pkg/mod/github.com/spf13/cobra@v0.0.5/command.go:830 +0x2aa
github.com/spf13/cobra.(*Command).ExecuteC(0xc000126a00, 0xc0000f0180, 0x35087c0, 0xc000010250)
        /home/maru/go/pkg/mod/github.com/spf13/cobra@v0.0.5/command.go:914 +0x2fb
github.com/spf13/cobra.(*Command).Execute(...)
        /home/maru/go/pkg/mod/github.com/spf13/cobra@v0.0.5/command.go:864
main.main()
        /home/maru/src/shist/cluster-openshift-controller-manager-operator/cmd/cluster-openshift-controller-manager-operator/main.go:29 +0x16f
exit status 2

@marun marun changed the title WIP Add make target to run operator with telepresence Bug 1834852: Add make target to run operator with telepresence May 13, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels May 13, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@marun: This pull request references Bugzilla bug 1834852, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

Bug 1834852: Add make target to run operator with telepresence

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@marun: This pull request references Bugzilla bug 1834852, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

Bug 1834852: Add make target to run operator with telepresence

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@marun marun changed the title Bug 1834852: Add make target to run operator with telepresence WIP Bug 1834852: Add make target to run operator with telepresence May 14, 2020
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 14, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@marun: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-upgrade 6b47e50 link /test e2e-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Copy Markdown
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 22, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: marun
To complete the pull request process, please assign bparees after the PR has been reviewed.
You can assign the PR to them by writing /assign @bparees in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jan 12, 2021

@marun: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws 8c0d785 link /test e2e-aws
ci/prow/e2e-upgrade 8c0d785 link /test e2e-upgrade
ci/prow/e2e-aws-operator 8c0d785 link /test e2e-aws-operator

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Copy Markdown
Contributor

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci-robot openshift-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 11, 2021
@openshift-bot
Copy link
Copy Markdown
Contributor

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@openshift-bot: Closed this PR.

Details

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@marun: This pull request references Bugzilla bug 1834852. The bug has been updated to no longer refer to the pull request using the external bug tracker.

Details

In response to this:

WIP Bug 1834852: Add make target to run operator with telepresence

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants