Skip to content

Switch to standard controller startup#10

Closed
deads2k wants to merge 5 commits intoopenshift:masterfrom
deads2k:switch-controllers
Closed

Switch to standard controller startup#10
deads2k wants to merge 5 commits intoopenshift:masterfrom
deads2k:switch-controllers

Conversation

@deads2k
Copy link
Copy Markdown
Contributor

@deads2k deads2k commented Oct 15, 2019

No description provided.

@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 15, 2019
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 15, 2019
@deads2k
Copy link
Copy Markdown
Contributor Author

deads2k commented Oct 15, 2019

this may actually make it harder to do the delta.

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 15, 2019
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@deads2k: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-upgrade 3de6e38 link /test e2e-aws-upgrade
ci/prow/e2e-aws 3de6e38 link /test e2e-aws
ci/prow/images 3de6e38 link /test images
ci/prow/unit 3de6e38 link /test unit

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@deads2k
Copy link
Copy Markdown
Contributor Author

deads2k commented Oct 16, 2019

Yeah, this won't happen until after we get it running and someone else can do it.

/close

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@deads2k: Closed this PR.

Details

In response to this:

Yeah, this won't happen until after we get it running and someone else can do it.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants