Bug 1910581: CSO shouldn't overwrite clustercsidriver objects#131
Conversation
openshift-ci-robot
added
the
bugzilla/severity-high
|
@bertinatto: This pull request references Bugzilla bug 1912945, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/invalid-bug
openshift-ci-robot
added
the
approved
|
/wip |
bertinatto
changed the title
|
@bertinatto: This pull request references Bugzilla bug 1912945, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/wip cancel |
|
/bugzilla refresh |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
@bertinatto: This pull request references Bugzilla bug 1912945, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
removed
the
bugzilla/invalid-bug
|
/retest |
bertinatto
changed the title
|
@bertinatto: This pull request references Bugzilla bug 1910581, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
1 similar comment
|
/retest |
| modified := resourcemerge.BoolPtr(false) | ||
| existingCopy := existing.DeepCopy() | ||
|
|
||
| resourcemerge.EnsureObjectMeta(modified, &existingCopy.ObjectMeta, required.ObjectMeta) |
There was a problem hiding this comment.
I think we might want to merge metadata of an object in-case there are some cluster-wide annotations applied to these CRs, but if we come to that we can also push and update and do metadata merging later on (so I am bit torn).
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bertinatto, gnufied The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@bertinatto: All pull requests linked via external trackers have merged: Bugzilla bug 1910581 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
5 participants
With this PR CSO will no longer update/patch the CR.
If the CR doesn't exist, CSO will create it. However, if the already CR exists, CSO won't update it with the config that it sees fit.
This is a requirement for the CSI Config Observer Controller used in CSI driver operators. That controller watches
proxiesresources and writes the observed config inCR.Spec.observedConfig. Without this PR, CSO would overwrite that field.CC @openshift/storage