Skip to content

WIP: Use library-go to check if feature gate is enabled#216

Closed
adambkaplan wants to merge 2 commits intoopenshift:masterfrom
adambkaplan:check-feature-library-go
Closed

WIP: Use library-go to check if feature gate is enabled#216
adambkaplan wants to merge 2 commits intoopenshift:masterfrom
adambkaplan:check-feature-library-go

Conversation

@adambkaplan
Copy link
Copy Markdown
Contributor

Use new library-go capability to check if a feature gate was enabled.

Update library-go to use new feature gates functions.
Use new library-go capability to check if a feature gate was enabled.
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 21, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 21, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: adambkaplan
To complete the pull request process, please assign jsafrane after the PR has been reviewed.
You can assign the PR to them by writing /assign @jsafrane in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 21, 2021

@adambkaplan: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-vsphere 066db16 link false /test e2e-vsphere
ci/prow/e2e-azure-csi 066db16 link false /test e2e-azure-csi
ci/prow/e2e-azure 066db16 link false /test e2e-azure
ci/prow/e2e-aws-upgrade 066db16 link true /test e2e-aws-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 17, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Oct 17, 2021

@adambkaplan: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jsafrane
Copy link
Copy Markdown
Contributor

jsafrane commented Nov 2, 2021

@adambkaplan are you going to finish this PR?

@adambkaplan
Copy link
Copy Markdown
Contributor Author

@jsafrane There's additional refactoring that I need to do in library-go, that needs to get merged first.

@adambkaplan
Copy link
Copy Markdown
Contributor Author

/close

At this point it will be easier to submit a new PR, assuming the code in library-go is merged first.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jan 5, 2022

@adambkaplan: Closed this PR.

Details

In response to this:

/close

At this point it will be easier to submit a new PR, assuming the code in library-go is merged first.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot closed this Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants