WIP: Use library-go to check if feature gate is enabled#216
WIP: Use library-go to check if feature gate is enabled#216adambkaplan wants to merge 2 commits intoopenshift:masterfrom
Conversation
Update library-go to use new feature gates functions.
Use new library-go capability to check if a feature gate was enabled.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: adambkaplan The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@adambkaplan: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@adambkaplan: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@adambkaplan are you going to finish this PR? |
|
@jsafrane There's additional refactoring that I need to do in library-go, that needs to get merged first. |
|
/close At this point it will be easier to submit a new PR, assuming the code in library-go is merged first. |
|
@adambkaplan: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Use new library-go capability to check if a feature gate was enabled.