Skip to content

MULTIARCH-4559: pkg/featuregates: Fix statusReleaseArchitecture enablement#1111

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
wking:fix-statusReleaseArchitecture-enablement
Nov 21, 2024
Merged

MULTIARCH-4559: pkg/featuregates: Fix statusReleaseArchitecture enablement#1111
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
wking:fix-statusReleaseArchitecture-enablement

Conversation

@wking
Copy link
Copy Markdown
Member

@wking wking commented Nov 21, 2024

Fixing my sloppy copy/paste typo from 28b3b40 (#1110).

Fixing my sloppy copy/paste typo from 28b3b40 (pkg: Propagate
Release.Architecture, 2024-11-18, openshift#1110).
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 21, 2024
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Nov 21, 2024

@wking: This pull request references MULTIARCH-4559 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

Details

In response to this:

Fixing my sloppy copy/paste typo from 28b3b40 (#1110).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 21, 2024
Copy link
Copy Markdown
Contributor

@PratikMahajan PratikMahajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Nov 21, 2024
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Nov 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: PratikMahajan, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [PratikMahajan,wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wking
Copy link
Copy Markdown
Member Author

wking commented Nov 21, 2024

tech-preview passed, and CVO logs still look fine:

$ curl -s https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/openshift_cluster-version-operator/1111/pull-ci-openshift-cluster-version-operator-master-e2e-aws-ovn-techpreview/1859629753502273536/artifacts/e2e-aws-ovn-techpreview/gather-extra/artifacts/pods/openshift-cluster-version_cluster-version-operator-58bb878c94-7ncz9_cluster-version-operator.log | grep -i architecture | grep -v 'Desired version from operator\|merge into existing history\|Synchronizing status\|Previous sync status'
I1121 16:43:24.928422       1 payload.go:402] Architecture from release-metadata (4.18.0-0.ci.test-2024-11-21-161859-ci-op-x01qxwk4-latest) retrieved from runtime: "amd64"
I1121 16:43:26.005331       1 start.go:590] CVO features for version 4.18.0-0.ci.test-2024-11-21-161859-ci-op-x01qxwk4-latest enabled at startup: {desiredVersion:4.18.0-0.ci.test-2024-11-21-161859-ci-op-x01qxwk4-latest unknownVersion:false reconciliationIssuesCondition:true statusReleaseArchitecture:true}
I1121 16:43:26.005386       1 featurechangestopper.go:123] Starting stop-on-features-change controller with startingRequiredFeatureSet="TechPreviewNoUpgrade" startingCvoGates={desiredVersion:4.18.0-0.ci.test-2024-11-21-161859-ci-op-x01qxwk4-latest unknownVersion:false reconciliationIssuesCondition:true statusReleaseArchitecture:true}
I1121 16:43:26.005991       1 payload.go:402] Architecture from release-metadata (4.18.0-0.ci.test-2024-11-21-161859-ci-op-x01qxwk4-latest) retrieved from runtime: "amd64"
I1121 16:43:26.965462       1 sync_worker.go:431] Payload loaded from registry.build05.ci.openshift.org/ci-op-x01qxwk4/release@sha256:7d314078d31f7acaa43ef1837a8d3c32ad69a0397b36afae549cb682a3ef8b77 with hash 4SZe-d8QZs4=, architecture amd64
I1121 16:43:26.965501       1 event.go:377] Event(v1.ObjectReference{Kind:"ClusterVersion", Namespace:"openshift-cluster-version", Name:"version", UID:"", APIVersion:"config.openshift.io/v1", ResourceVersion:"", FieldPath:""}): type: 'Normal' reason: 'PayloadLoaded' Payload loaded version="4.18.0-0.ci.test-2024-11-21-161859-ci-op-x01qxwk4-latest" image="registry.build05.ci.openshift.org/ci-op-x01qxwk4/release@sha256:7d314078d31f7acaa43ef1837a8d3c32ad69a0397b36afae549cb682a3ef8b77" architecture="amd64"

Merging again to retest in the next multi-arch nightly.

/label no-qe
/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci Bot added no-qe Allows PRs to merge without qe-approved label acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. labels Nov 21, 2024
@wking
Copy link
Copy Markdown
Member Author

wking commented Nov 21, 2024

HyperShift:

2024-11-21 17:43:18+00:00 Clusteroperators not yet ready
NAME      VERSION   AVAILABLE   PROGRESSING   SINCE   STATUS
version             False       True          43m     Unable to apply 4.17.5: the cluster operator console is not available
{"component":"entrypoint","file":"sigs.k8s.io/prow/pkg/entrypoint/run.go:169","func":"sigs.k8s.io/prow/pkg/entrypoint.Options.ExecuteProcess","level":"error","msg":"Process did not finish before 45m0s timeout","severity":"error","time":"2024-11-21T17:43:26Z"}

Some kind of Route issue:

$ curl -s https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/openshift_cluster-version-operator/1111/pull-ci-openshift-cluster-version-operator-master-e2e-hypershift/1859629753569382400/artifacts/e2e-hypershift/dump-management-cluster/artifacts/artifacts.tar | tar -xOz logs/artifacts/output/hostedcluster-4d04fa6c54655f0d374d-mgmt/cluster-scoped-resources/config.openshift.io/clusteroperators/console.yaml | yaml2json | jq -r '.status.conditions[] | select(.type == "Available")'
{
  "lastTransitionTime": "2024-11-21T17:07:09Z",
  "message": "RouteHealthAvailable: failed to GET route (https://console-openshift-console.apps.4d04fa6c54655f0d374d-mgmt.ci.hypershift.devcluster.openshift.com): Get \"https://console-openshift-console.apps.4d04fa6c54655f0d374d-mgmt.ci.hypershift.devcluster.openshift.com\": EOF",
  "reason": "RouteHealth_FailedGet",
  "status": "False",
  "type": "Available"
}

Not a tech-preview run though, so not my code change here.

/override ci/prow/e2e-hypershift

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Nov 21, 2024

@wking: Overrode contexts on behalf of wking: ci/prow/e2e-hypershift

Details

In response to this:

HyperShift:

2024-11-21 17:43:18+00:00 Clusteroperators not yet ready
NAME      VERSION   AVAILABLE   PROGRESSING   SINCE   STATUS
version             False       True          43m     Unable to apply 4.17.5: the cluster operator console is not available
{"component":"entrypoint","file":"sigs.k8s.io/prow/pkg/entrypoint/run.go:169","func":"sigs.k8s.io/prow/pkg/entrypoint.Options.ExecuteProcess","level":"error","msg":"Process did not finish before 45m0s timeout","severity":"error","time":"2024-11-21T17:43:26Z"}

Some kind of Route issue:

$ curl -s https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/openshift_cluster-version-operator/1111/pull-ci-openshift-cluster-version-operator-master-e2e-hypershift/1859629753569382400/artifacts/e2e-hypershift/dump-management-cluster/artifacts/artifacts.tar | tar -xOz logs/artifacts/output/hostedcluster-4d04fa6c54655f0d374d-mgmt/cluster-scoped-resources/config.openshift.io/clusteroperators/console.yaml | yaml2json | jq -r '.status.conditions[] | select(.type == "Available")'
{
 "lastTransitionTime": "2024-11-21T17:07:09Z",
 "message": "RouteHealthAvailable: failed to GET route (https://console-openshift-console.apps.4d04fa6c54655f0d374d-mgmt.ci.hypershift.devcluster.openshift.com): Get \"https://console-openshift-console.apps.4d04fa6c54655f0d374d-mgmt.ci.hypershift.devcluster.openshift.com\": EOF",
 "reason": "RouteHealth_FailedGet",
 "status": "False",
 "type": "Available"
}

Not a tech-preview run though, so not my code change here.

/override ci/prow/e2e-hypershift

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Nov 21, 2024

@wking: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 45ed2e4 link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit 820b74a into openshift:master Nov 21, 2024
@wking wking deleted the fix-statusReleaseArchitecture-enablement branch November 21, 2024 19:26
@openshift-bot
Copy link
Copy Markdown
Contributor

[ART PR BUILD NOTIFIER]

Distgit: cluster-version-operator
This PR has been included in build cluster-version-operator-container-v4.19.0-202411212037.p0.g820b74a.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. no-qe Allows PRs to merge without qe-approved label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants