Skip to content

OCPBUGS-73601: vendor: Update openshift/library-go to get new default TLS configuration#1290

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:release-4.21from
sanchezl:cherry-pick-1270-to-release-4.21
Jan 13, 2026
Merged

OCPBUGS-73601: vendor: Update openshift/library-go to get new default TLS configuration#1290
openshift-merge-bot[bot] merged 1 commit intoopenshift:release-4.21from
sanchezl:cherry-pick-1270-to-release-4.21

Conversation

@sanchezl
Copy link
Copy Markdown

@sanchezl sanchezl commented Jan 12, 2026

Manual cherry-pick of #1270.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jan 12, 2026

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)
  • do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Comment @coderabbitai help to get the list of available commands and usage tips.

@sanchezl sanchezl changed the title bump(library-go bump(library-go) Jan 12, 2026
@sanchezl
Copy link
Copy Markdown
Author

/jira cherrypick OCPBUGS-17007

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@sanchezl: Jira Issue OCPBUGS-17007 has been cloned as Jira Issue OCPBUGS-73601. Will retitle bug to link to clone.
/retitle OCPBUGS-73601: bump(library-go)

Details

In response to this:

/jira cherrypick OCPBUGS-17007

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot changed the title bump(library-go) OCPBUGS-73601: bump(library-go) Jan 12, 2026
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jan 12, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@sanchezl: This pull request references Jira Issue OCPBUGS-73601, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.21.0) matches configured target version for branch (4.21.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-17007 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-17007 targets the "4.22.0" version, which is one of the valid target versions: 4.22.0
  • bug has dependents

Requesting review from QA contact:
/cc @jiajliu

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Manual cherry-pick of #1270.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot requested a review from jiajliu January 12, 2026 16:11
@sanchezl sanchezl changed the title OCPBUGS-73601: bump(library-go) OCPBUGS-73601: vendor: Update openshift/library-go to get new default TLS configuration Jan 12, 2026
Copy link
Copy Markdown
Member

@wking wking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything matches #1290 (including the vendored library-go code) except for the exact library-go hash, so looks good to me.

/lgtm
/label backport-risk-accepted

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jan 12, 2026

@wking: The label(s) /label backport-risk-accepted cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, ux-approved, no-qe, downstream-change-needed, rebase/manual, cluster-config-api-changed, run-integration-tests, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, jira/valid-bug, ok-to-test, stability-fix-approved, staff-eng-approved. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

Details

In response to this:

Everything matches #1290 (including the vendored library-go code) except for the exact library-go hash, so looks good to me.

/lgtm
/label backport-risk-accepted

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jan 12, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jan 12, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sanchezl, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wking
Copy link
Copy Markdown
Member

wking commented Jan 12, 2026

oops, typo'ed the label.

/label backport-risk-assessed

@openshift-ci openshift-ci Bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. labels Jan 12, 2026
@kaleemsiddiqu
Copy link
Copy Markdown

/retest

@kaleemsiddiqu
Copy link
Copy Markdown

/verified by @kaleemsiddiqu
Test result available at https://issues.redhat.com/browse/OCPBUGS-17349#comment-28802602

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jan 13, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@kaleemsiddiqu: This PR has been marked as verified by @kaleemsiddiqu.

Details

In response to this:

/verified by @kaleemsiddiqu
Test result available at https://issues.redhat.com/browse/OCPBUGS-17349#comment-28802602

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jan 13, 2026

@sanchezl: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit 2e80794 into openshift:release-4.21 Jan 13, 2026
16 checks passed
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@sanchezl: Jira Issue Verification Checks: Jira Issue OCPBUGS-73601
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-73601 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

Manual cherry-pick of #1270.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot
Copy link
Copy Markdown
Contributor

Fix included in accepted release 4.21.0-0.nightly-2026-01-17-030111

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants