Skip to content

Bug 1825003: pkg/payload/task: Include name/reason in "unknown error" message#185

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
wking:more-specific-unknown-error-reporting
Apr 17, 2020
Merged

Bug 1825003: pkg/payload/task: Include name/reason in "unknown error" message#185
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
wking:more-specific-unknown-error-reporting

Conversation

@wking
Copy link
Copy Markdown
Member

@wking wking commented May 14, 2019

Because this makes it easier to grow the SummaryForReason logic. The previous, generic error message is not very useful (e.g. as seen here).

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 14, 2019
@wking wking changed the title pkg/payload/task: Include name/reason in "unknown error" message Bug 1825003: pkg/payload/task: Include name/reason in "unknown error" message Apr 16, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Apr 16, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@wking: This pull request references Bugzilla bug 1825003, which is invalid:

  • expected the bug to target the "4.5.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1825003: pkg/payload/task: Include name/reason in "unknown error" message

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking
Copy link
Copy Markdown
Member Author

wking commented Apr 16, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Apr 16, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@wking: This pull request references Bugzilla bug 1825003, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Apr 16, 2020
Comment thread pkg/payload/task.go Outdated
Because this makes it easier to grow the SummaryForReason logic.  The
previous, generic error message is not very useful (e.g. as seen in
[1]).

[1]: https://bugzilla.redhat.com/show_bug.cgi?id=1710012#c0
@wking wking force-pushed the more-specific-unknown-error-reporting branch from 27c83fc to 2b06b79 Compare April 16, 2020 23:30
@abhinavdahiya
Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 16, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [abhinavdahiya,wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wking
Copy link
Copy Markdown
Member Author

wking commented Apr 17, 2020

e2e-aws was super-close, failing on:

[sig-storage] In-tree Volumes [Driver: aws] [Testpattern: Dynamic PV (default fs)(allowExpansion)] volume-expand Verify if offline PVC expansion works [Suite:openshift/conformance/parallel] [Suite:k8s] expand_less | 6m33s
-- | --
fail [k8s.io/kubernetes/test/e2e/storage/testsuites/volume_expand.go:211]: while recreating pod for resizing Unexpected error:     <*errors.errorString \| 0xc00264a4e0>: {         s: "pod \"security-context-444dd69b-0b98-43ef-95b1-7814f47a0e39\" is not Running: timed out waiting for the condition",     }     pod "security-context-444dd69b-0b98-43ef-95b1-7814f47a0e39" is not Running: timed out waiting for the condition occurred

/retest

@openshift-merge-robot openshift-merge-robot merged commit 914467c into openshift:master Apr 17, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@wking: All pull requests linked via external trackers have merged: openshift/cluster-version-operator#185. Bugzilla bug 1825003 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1825003: pkg/payload/task: Include name/reason in "unknown error" message

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking wking deleted the more-specific-unknown-error-reporting branch April 17, 2020 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants