status: Simplify operator not available status#190
Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom May 20, 2019
Merged
status: Simplify operator not available status#190openshift-merge-robot merged 1 commit intoopenshift:masterfrom
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
Conversation
In practice, the output of displaying version operands is redundant and our current use doesn't require it. Since the core output is "we are going to X, these are the things not there yet" also showing "we are going to X, these are the things not there yet A-X,B-X,C-X" makes it harder to understand what is going on. Strip all sub version reporting from cluster operators, and in the future we can improve this if we have a use case.
openshift-ci-robot
added
approved
Contributor
Author
|
/retest |
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, smarterclayton The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In practice, the output of displaying version operands is redundant and our current use doesn't require it. Since the core output is
"we are going to X, these are the things not there yet"
also showing
"we are going to X, these are the things not there yet A-X,B-X,C-X"
makes it harder to understand what is going on.
Strip all sub version reporting from cluster operators, and in the future we can improve this if we have a use case.
Encountered while debugging failure output in upgrades - the key messages are always the actual Degraded conditition, and the extra versions are always variants of the operator version.
https://openshift-gce-devel.appspot.com/build/origin-ci-test/logs/release-openshift-origin-installer-e2e-aws-upgrade/1724/
The first message is almost completely wasted space.
/cherrypick release-4.1