Bug 1717619: metrics: Report reason as a label on the conditions metric

[smarterclayton]

Conditions are read by telemetry and the reason incentivizes teams
to have good reasons on their operators. Should not increase
cardinality significantly, but instead provide better insight.

/cherry-pick release-4.1

[smarterclayton]

/assign @abhinavdahiya

[abhinavdahiya]

/lgtm

/retest

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [abhinavdahiya,smarterclayton]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[smarterclayton]

/retest

[abhinavdahiya]

/cherry-pick release-4.1

[abhinavdahiya]

/cherrypick release-4.1

[openshift-cherrypick-robot]

@abhinavdahiya: #197 failed to apply on top of branch "release-4.1":

error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	docs/dev/metrics.md
M	pkg/cvo/metrics.go
M	pkg/cvo/metrics_test.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/cvo/metrics_test.go
Auto-merging pkg/cvo/metrics.go
Auto-merging docs/dev/metrics.md
CONFLICT (content): Merge conflict in docs/dev/metrics.md
Patch failed at 0001 metrics: Report reason as a label on the conditions metric

Details

In response to this:

/cherrypick release-4.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[smarterclayton]

@abhinavdahiya we need this in 4.1.2, could you get someone to backport today?