Skip to content

Bug 1717619: metrics: Report reason as a label on the conditions metric#200

Closed
abhinavdahiya wants to merge 2 commits intoopenshift:masterfrom
abhinavdahiya:pick-197
Closed

Bug 1717619: metrics: Report reason as a label on the conditions metric#200
abhinavdahiya wants to merge 2 commits intoopenshift:masterfrom
abhinavdahiya:pick-197

Conversation

@abhinavdahiya
Copy link
Copy Markdown
Contributor

@abhinavdahiya abhinavdahiya commented Jun 11, 2019

@smarterclayton @abhinavdahiya
conditions: Use a consistent constant for the Failing condition
05a4e25 
This needs to be moved back into openshift/api since it is now part
of our public API, but for now ensure it is consistently used.
@smarterclayton @abhinavdahiya
metrics: Report reason as a label on the conditions metric
b820c53 
Conditions are read by telemetry and the reason incentivizes teams
to have good reasons on their operators. Should not increase
cardinality significantly, but instead provide better insight.
@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jun 11, 2019
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Jun 11, 2019

@abhinavdahiya: This pull request references a valid Bugzilla bug.

Details

In response to this:

Bug 1717619: metrics: Report reason as a label on the conditions metric

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 11, 2019
@smarterclayton
Copy link
Copy Markdown
Contributor

smarterclayton commented Jun 11, 2019

/lgtm
/approve
/cherry-pick-approved

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 11, 2019
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Jun 11, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [abhinavdahiya,smarterclayton]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@smarterclayton
Copy link
Copy Markdown
Contributor

smarterclayton commented Jun 11, 2019

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 11, 2019
@smarterclayton
Copy link
Copy Markdown
Contributor

smarterclayton commented Jun 11, 2019

Wait, why is this against the master branch?

@smarterclayton smarterclayton removed approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels Jun 11, 2019
@abhinavdahiya
Copy link
Copy Markdown
Contributor Author

abhinavdahiya commented Jun 11, 2019

This was meant to be on release-4.1

closing this for #202

@abhinavdahiya abhinavdahiya deleted the pick-197 branch June 17, 2019 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@smarterclayton smarterclayton

Labels

bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@abhinavdahiya @openshift-ci-robot @smarterclayton