Skip to content

manifests: Update the CRD definitions with more accurate docs#225

Merged
openshift-merge-robot merged 1 commit into
openshift:masterfrom
smarterclayton:add_crds
Jul 30, 2019
Merged

manifests: Update the CRD definitions with more accurate docs#225
openshift-merge-robot merged 1 commit into
openshift:masterfrom
smarterclayton:add_crds

Conversation

@smarterclayton
Copy link
Copy Markdown
Contributor

@smarterclayton smarterclayton commented Jul 22, 2019

This refreshes our CRD schema with the latest copies from the 4.2
streams. Docs are regenerated from tooling in cluster-config-operator
and merged with the current definition.

  1. Go to openshift/cluster-config-operator
  2. Build crd-schema-gen, invoke it like crd-schema-gen --apis-dir vendor/github.com/openshift/api/config/v1/ -output-dir manifests
  3. Copy the generated clusterversion/operator manifests over the CRDS in repo
  4. Merge the schema portion only in (dropping other changes)

This refreshes our CRD schema with the latest copies from the 4.2
streams. Docs are regenerated from tooling in cluster-config-operator
and merged with the current definition.
@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 22, 2019
@smarterclayton
Copy link
Copy Markdown
Contributor Author

/assign @abhinavdahiya

Bug incoming. I figure we'll potentially want to script this like cluster-config-operator in the future, it's not quite there yet.

@smarterclayton
Copy link
Copy Markdown
Contributor Author

smarterclayton commented Jul 22, 2019

Hrm. I need to check whether the schema is too restrictive. It looks like some of the optional fields are optional.

@smarterclayton
Copy link
Copy Markdown
Contributor Author

/retest

@abhinavdahiya
Copy link
Copy Markdown
Contributor

@smarterclayton
#168 added the wiring to call update-crd-gen ??
that's not sufficient??

@smarterclayton
Copy link
Copy Markdown
Contributor Author

No it doesn't, but I'll have to dig in why later. I think the version is too old. Suggest we merge this, then I'll dig in once we get closer to feature freeze.

/retest

@abhinavdahiya
Copy link
Copy Markdown
Contributor

No it doesn't, but I'll have to dig in why later. I think the version is too old. Suggest we merge this, then I'll dig in once we get closer to feature freeze.

/retest

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 30, 2019
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [abhinavdahiya,smarterclayton]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit b3161a6 into openshift:master Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants