pkg/verify: Use a more-specific digest regular expression #284
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
approved
|
/retest |
wking
force-pushed
the
more-specific-digest-regular-expression
branch
from
fac4277 to
a3aa56c
Compare
|
@wking: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@wking: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
openshift-ci-robot
added
the
lifecycle/stale
Use the expression from [1], based on the spec in [2]. We'd get more robust validation by using go-digest directly, but that would require a vendoring bump while bumping our regexp does not. [1]: https://github.com/opencontainers/go-digest/blob/v1.0.0-rc1/digest.go#L62 [2]: https://github.com/opencontainers/image-spec/blob/v1.0.1/descriptor.md#digests
wking
force-pushed
the
more-specific-digest-regular-expression
branch
from
a3aa56c to
9d556f4
Compare
|
Ah, moved to openshift/library-go#1032 to follow the code I'm trying to patch. /close |
|
@wking: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
4 participants
Use the expression from go-digest, based on this spec. We'd get more robust validation by using go-digest directly, but that would require a vendoring bump while bumping our regexp does not.