Skip to content

Conversation

@wking
Copy link
Member

@wking wking commented May 20, 2020

If we considered Degraded=True something that impacted update stability, I expect we'd want a guard against it that blocked new updates until admins coaxed the operator back into happiness. This commit softens wording from af62f04 (#232).

/assign @abhinavdahiya

…table" from ClusterOperatorDegraded

If we considered Degraded=True something that impacted update
stability, I expect we'd want a guard against it that blocked new
updates until admins coaxed the operator back into happiness.  This
commit softens wording from af62f04 (install: add alerts for
cluster-version-operator, 2019-08-07, openshift#232).
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 20, 2020
@wking
Copy link
Member Author

wking commented May 26, 2020

And apparently I was wrong. While we don't consider Degraded=True sufficient to block update initialization, we do consider it sufficient to block manifest-graph application (except for installation).

/close

@openshift-ci-robot
Copy link
Contributor

@wking: Closed this PR.

Details

In response to this:

And apparently I was wrong. While we don't consider Degraded=True sufficient to block update initialization, we do consider it sufficient to block manifest-graph application (except for installation).

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking wking deleted the degraded-operators-do-not-impact-update-stability branch May 27, 2020 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants