pkg/verify/store/sigstore: Factor HTTP store into its own package #396
Conversation
openshift-ci-robot
added
the
approved
wking
force-pushed
the
push-http-signature-store-to-subpackage
branch
from
ac60956 to
d8afaa3
Compare
Decluttering the root verify package and making it more store-agnostic. I've also replaced the ClientBuilder interface with a single HTTPClient function type, which removes the need for verifyClientBuilder and other wrappers. I'm also adding a rate-limiter around the client builder to avoid pounding away at that logic, even if it's mostly fed through informers (so should be no API-call reduction, but will save some local CPU cycles).
wking
force-pushed
the
push-http-signature-store-to-subpackage
branch
from
d8afaa3 to
e5a075b
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jottofar, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@wking: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
5 participants
Decluttering the root verify package and making it more store-agnostic.
I've also replaced the
ClientBuilderinterface with a singleHTTPClientfunction type, which removes the need forverifyClientBuilderand other wrappers. I'm also adding a rate-limiter around the client builder to avoid pounding away at that logic, even if it's mostly fed through informers (so should be no API-call reduction, but will save some local CPU cycles).Spun off from my earlier 0cc3e41 as another nibbly bit (hopefully easy to review), now that the bulk of the earlier change has landed via #294. Still to go after this change will be a similar sub-package for the file store, or deprecating the file store in favor of #294's memory store for unit testing.