Bug 1872080: Dockerfile.rhel: Use a RHEL-version-agnostic filename#444
Conversation
openshift-ci-robot
added
bugzilla/severity-medium
|
@wking: This pull request references Bugzilla bug 1872080, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
approved
wking
force-pushed
the
rhel-version-agnostic-dockerfile
branch
2 times, most recently
from
32dabbc to
1100906
Compare
|
makes sense to me but others can have a look as well |
openshift-ci-robot
added
the
do-not-merge/hold
So we don't have a nominally-rhel7 Dockerfile building RHEL 8 images and also so we don't need to manually bump this filename when we bump RHEL versions. We've had a RHEL 8 base since a4044f4 (Updating Dockerfile.rhel7 baseimages to mach ocp-build-data config, 2020-08-24, openshift#442). Once consumers have updated, we can remove the backwards-compat symlink.
wking
force-pushed
the
rhel-version-agnostic-dockerfile
branch
from
1100906 to
32204c0
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jottofar, LalatenduMohanty, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel Both Lala and Jack have chimed in. |
openshift-ci-robot
removed
the
do-not-merge/hold
|
@wking: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged: These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Bugzilla bug 1872080 has not been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Because we don't care if it's 7 or 8. Catches up with openshift/cluster-version-operator@32204c00ba (Dockerfile.rhel: Use a RHEL-version-agnostic filename, 2020-08-25, openshift/cluster-version-operator#444).
Because we don't care if it's 7 or 8. Catches up with openshift/cluster-version-operator@32204c00ba (Dockerfile.rhel: Use a RHEL-version-agnostic filename, 2020-08-25, openshift/cluster-version-operator#444).
5 participants
So we don't have a nominally-rhel7 Dockerfile building RHEL 8 images and also so we don't need to manually bump this filename when we bump RHEL versions.