Skip to content

pkg/cvo/upgradeable: Fix "Upgradebale" -> "Upgradeable" #459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Feb 10, 2021
Merged

pkg/cvo/upgradeable: Fix "Upgradebale" -> "Upgradeable" #459

openshift-merge-robot merged 1 commit into from
Feb 10, 2021

Conversation

@wking
Copy link
Member

@wking wking commented Sep 18, 2020

Fixing a typo from 0452814 (#243).

Generated with:

$ sed -i 's/Upgradebale/Upgradeable/g' $(git grep -l Upgradebale)

No rush; we can land this after 4.6 forks off and master reopens.

@wking
pkg/cvo/upgradeable: Fix "Upgradebale" -> "Upgradeable"
146defe 
Fixing a typo from 0452814 (cvo: long running upgradeable sync
worker, 2019-09-05, openshift#243).

Generated with:

  $ sed -i 's/Upgradebale/Upgradeable/g' $(git grep -l Upgradebale)
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 18, 2020
LalatenduMohanty
LalatenduMohanty approved these changes Sep 21, 2020
View reviewed changes
Copy link
Member

@LalatenduMohanty LalatenduMohanty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 21, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 21, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LalatenduMohanty, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [LalatenduMohanty,wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

openshift-bot commented Sep 21, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

12 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Sep 21, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Sep 21, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Sep 21, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Sep 21, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Sep 21, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Sep 21, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Sep 21, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Sep 21, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Sep 21, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Sep 21, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Sep 22, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Sep 22, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@sdodson
Copy link
Member

sdodson commented Sep 22, 2020

/hold
We need to look at why these tests are always failing

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 22, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 22, 2020

@wking: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e 146defe link /test e2e

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@LalatenduMohanty
Copy link
Member

LalatenduMohanty commented Nov 11, 2020

/retest

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Dec 9, 2020

@wking: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-agnostic-upgrade 146defe link /test e2e-agnostic-upgrade
ci/prow/e2e-agnostic-operator 146defe link /test e2e-agnostic-operator

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jottofar
Copy link
Contributor

jottofar commented Feb 3, 2021

/test e2e-agnostic-upgrade

@wking
Copy link
Member Author

wking commented Feb 9, 2021

/retest

@wking
Copy link
Member Author

wking commented Feb 10, 2021

e2e-operator passed:

2021/02/09 21:24:27 Container test in pod e2e-agnostic-operator-e2e-test completed successfully

And then died on some gather flake.

/override ci/prow/e2e-agnostic-operator

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 10, 2021

@wking: Overrode contexts on behalf of wking: ci/prow/e2e-agnostic-operator

Details

In response to this:

e2e-operator passed:

2021/02/09 21:24:27 Container test in pod e2e-agnostic-operator-e2e-test completed successfully

And then died on some gather flake.

/override ci/prow/e2e-agnostic-operator

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking
Copy link
Member Author

wking commented Feb 10, 2021

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 10, 2021
@wking
Copy link
Member Author

wking commented Feb 10, 2021

/test unit

The usual race

@openshift-merge-robot openshift-merge-robot merged commit a9a80fe into openshift:master Feb 10, 2021
@wking wking deleted the upgradebale-typo branch April 6, 2021 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sdodson sdodson Awaiting requested review from sdodson

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

1 more reviewer

@LalatenduMohanty LalatenduMohanty LalatenduMohanty approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@LalatenduMohanty LalatenduMohanty

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@wking @openshift-ci-robot @openshift-bot @sdodson @LalatenduMohanty @openshift-merge-robot @jottofar