Skip to content

docs/dev/clusteroperator: Fix "he" -> "the" typo #479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Nov 11, 2020
Merged

docs/dev/clusteroperator: Fix "he" -> "the" typo #479

openshift-merge-robot merged 1 commit into from
Nov 11, 2020

Conversation

@wking
Copy link
Member

@wking wking commented Oct 31, 2020

This snuck in with be09d1e (#478).

Re: "or recreate if deleted", the CVO (if it is running) will eventually get around to recreating the ClusterOperator, as described in the text added in be09d1e. But it's still the operator's job to recreate it if the ClusterOperator is missing, as part of the "properly update" responsibility.

@wking
docs/dev/clusteroperator: Fix "he" -> "the" typo
1d678d0 
This snuck in with be09d1e (Doc fix for cluster operator creation
step, 2020-10-30, openshift#478).

Re: "or recreate if deleted", the CVO (if it is running) will
eventually get around to recreating the ClusterOperator, as described
in the text added in be09d1e.  But it's still the operator's job to
recreate it if the ClusterOperator is missing, as part of the
"properly update" responsibility.
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 31, 2020
@dmage
Copy link

dmage commented Nov 11, 2020

/test integration

@LalatenduMohanty
Copy link
Member

LalatenduMohanty commented Nov 11, 2020

Integration job failing with

I1111 05:32:19.459131     335 flags.go:59] FLAG: --watch-cache="true"
I1111 05:32:19.459134     335 flags.go:59] FLAG: --watch-cache-sizes="[]"
Error: error creating self-signed certificates: mkdir /var/run/kubernetes: permission denied

https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_cluster-version-operator/479/pull-ci-openshift-cluster-version-operator-master-integration/1326396726751268864

LalatenduMohanty
LalatenduMohanty approved these changes Nov 11, 2020
View reviewed changes
Copy link
Member

@LalatenduMohanty LalatenduMohanty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 11, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 11, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LalatenduMohanty, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [LalatenduMohanty,wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@sdodson
Copy link
Member

sdodson commented Nov 11, 2020

/override ci/prow/integration

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 11, 2020

@sdodson: Overrode contexts on behalf of sdodson: ci/prow/integration

Details

In response to this:

/override ci/prow/integration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit dc6f4f0 into openshift:master Nov 11, 2020
@wking wking deleted the he-the-typo branch November 11, 2020 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abhinavdahiya abhinavdahiya Awaiting requested review from abhinavdahiya

1 more reviewer

@LalatenduMohanty LalatenduMohanty LalatenduMohanty approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@LalatenduMohanty LalatenduMohanty

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@wking @dmage @LalatenduMohanty @openshift-ci-robot @openshift-bot @sdodson @openshift-merge-robot