Skip to content

Enable structcheck #605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Jun 23, 2021
Merged

Enable structcheck #605

openshift-merge-robot merged 1 commit into from
Jun 23, 2021

Conversation

@arjunrn
Copy link
Contributor

@arjunrn arjunrn commented Jun 14, 2021 •
edited
Loading

Depends on #598

The structcheck linter finds unused fields in structs.

@openshift-ci openshift-ci bot requested review from sdodson and vrutkovs June 14, 2021 11:15
@arjunrn
Copy link
Contributor Author

arjunrn commented Jun 15, 2021

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 15, 2021
@arjunrn arjunrn force-pushed the enable-structcheck branch from 8655045 to 27858eb Compare June 17, 2021 09:37
@arjunrn
Copy link
Contributor Author

arjunrn commented Jun 17, 2021

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 17, 2021
@arjunrn
Enable structcheck and fix detected issues
6928039 
Signed-off-by: Arjun Naik <arjun.rn@gmail.com>
@arjunrn arjunrn force-pushed the enable-structcheck branch from 27858eb to 6928039 Compare June 17, 2021 09:44
@arjunrn
Copy link
Contributor Author

arjunrn commented Jun 18, 2021

/assign @LalatenduMohanty

@vrutkovs
Copy link

vrutkovs commented Jun 22, 2021

/retest

vrutkovs
vrutkovs approved these changes Jun 23, 2021
View reviewed changes
Copy link

@vrutkovs vrutkovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/override ci/prow/e2e-agnostic-upgrade

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 23, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 23, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arjunrn, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 23, 2021

@vrutkovs: Overrode contexts on behalf of vrutkovs: ci/prow/e2e-agnostic-upgrade

Details

In response to this:

/lgtm
/override ci/prow/e2e-agnostic-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 23, 2021
@openshift-merge-robot openshift-merge-robot merged commit f8e8cc6 into openshift:master Jun 23, 2021
@arjunrn arjunrn deleted the enable-structcheck branch June 23, 2021 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sdodson sdodson Awaiting requested review from sdodson

1 more reviewer

@vrutkovs vrutkovs vrutkovs approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@vrutkovs vrutkovs

@LalatenduMohanty LalatenduMohanty

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@arjunrn @vrutkovs @LalatenduMohanty @openshift-merge-robot