Bug 1978376: Add admin ack Upgradeable condition gate

[jottofar]

This PR adds a generic upgrade blocking mechanism for blocking minor level upgrades. It is the general implementation of the Add admin ack upgrade gate enhancement. Therefore since 4.9 does not contain any active admin ack gates the check clusterAdminAcksCompletedUpgradeable is not added to defaultUpgradeableChecks. It is added as part of unit test and tested.

This PR will be backported to 4.8.z and the 4.8 specific implementation details will be added, i.e. the ack-4.8-kube-122-api-removals-in-4.9 gate will be added by adding check clusterAdminAcksCompletedUpgradeable to defaultUpgradeableChecks.

Once active the clusterAdminAcksCompletedUpgradeable Upgradeable check implementation differs from other Upgradeable checks by also being synchronously triggered when either configmap admin-gates or admin-acks is added, updated, or deleted. This will be achieved by adding an event handler to the cmConfigInformer and cmConfigManagedInformer Informers. The event handlers will simply invoke setUpgradeableConditions to ensure all conditions are properly evaluated. Since the check will be added as a default Upgradeable check when active it will also be evaluated during the existing periodic polling of Upgradeable conditions.

I also removed the unused parameter config from cvo.syncUpgradeable.

[openshift-ci]

@jottofar: This pull request references Bugzilla bug 1978376, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.9.0) matches configured target release for branch (4.9.0)
• bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @jianlinliu

Details

In response to this:

WIP: Bug 1978376: Add admin ack gate for deleted apis

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jottofar]

/hold

[jottofar]

/unhold

[jottofar]

Tightened up gate regex to require one and only one following dash followed by something, i.e. the description. Changed error message to simply spit out "must comply with" and the regex expression itself since it's too hard to explain and these errors should only be consumed by developers. If an admin does add a gate in the field I don't think it's too much to ask that they understand regex.

[jottofar]

/retest

[wking]

/lgtm
/retest

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jottofar, LalatenduMohanty, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [LalatenduMohanty,jottofar,wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[wking]

The update job had terrible API-server / ingress connectivity. That's being tracked in rhbz#1955333 and/or rhbz#1997057, and is orthogonal to this PR, so:

/override ci/prow/e2e-agnostic-upgrade

[openshift-ci]

@wking: Overrode contexts on behalf of wking: ci/prow/e2e-agnostic-upgrade

Details

In response to this:

The update job had terrible API-server / ingress connectivity. That's being tracked in rhbz#1955333 and/or rhbz#1997057, and is orthogonal to this PR, so:

/override ci/prow/e2e-agnostic-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@jottofar: All pull requests linked via external trackers have merged:

• openshift/cluster-version-operator#633
• openshift/enhancements#828

Bugzilla bug 1978376 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1978376: Add admin ack Upgradeable condition gate

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jottofar]

/cherry-pick release-4.8

[openshift-cherrypick-robot]

@jottofar: #633 failed to apply on top of branch "release-4.8":

Applying: Bug 1978376: Add admin ack Upgradeable condition gate
Using index info to reconstruct a base tree...
M	pkg/cvo/cvo.go
M	pkg/cvo/cvo_test.go
M	pkg/cvo/upgradeable.go
M	pkg/payload/precondition/clusterversion/upgradable_test.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/payload/precondition/clusterversion/upgradable_test.go
Auto-merging pkg/cvo/upgradeable.go
CONFLICT (content): Merge conflict in pkg/cvo/upgradeable.go
Auto-merging pkg/cvo/cvo_test.go
CONFLICT (content): Merge conflict in pkg/cvo/cvo_test.go
Auto-merging pkg/cvo/cvo.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Bug 1978376: Add admin ack Upgradeable condition gate
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

/cherry-pick release-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.