Bug 2091806: pkg/cvo: Separate payload load from payload apply

[jottofar]

Back-port 35b0f4f and a16c4ce to 4.9. There were many subsequent fix-up and issue resolution commits related to this original change in 4.11 but as explained below, these other commits are not required for this back-port.

In addition to splitting the load and application of a given payload into two separate goroutines, the original PR #683 also created a new condition, DesiredReleaseAccepted, indicating whether the requested (desired) release payload was successfully loaded. This portion of the original PR has not been back-ported thereby not requiring changes to Etcd or the oc client to account for the new condition. There are also two other new condition related fix-up commits, 4caab8e and a1d0687, that do not have to be back-ported.

Other related commits that do not require back-porting are:

• 3af0020 - Fix-up portion is not required since no new condition. Other event rewording changes are non-critical and cause significant unit test changes.
• • 1ee22b6 was actually caused by Capabilities changes.

[openshift-ci]

@jottofar: This pull request references Bugzilla bug 2091806, which is invalid:

• expected the bug to target the "4.9.z" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 2091806: pkg/cvo: Separate payload load from payload apply

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jottofar]

/bugzilla refresh

[openshift-ci]

@jottofar: This pull request references Bugzilla bug 2091806, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.9.z) matches configured target release for branch (4.9.z)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
• dependent bug Bugzilla bug 2064991 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
• dependent Bugzilla bug 2064991 targets the "4.10.z" release, which is one of the valid target releases: 4.10.0, 4.10.z
• bug has dependents

Requesting review from QA contact:
/cc @jiajliu

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@jottofar: This pull request references Bugzilla bug 2091806, which is valid.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.9.z) matches configured target release for branch (4.9.z)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
• dependent bug Bugzilla bug 2064991 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
• dependent Bugzilla bug 2064991 targets the "4.10.z" release, which is one of the valid target releases: 4.10.0, 4.10.z
• bug has dependents

Requesting review from QA contact:
/cc @jiajliu

Details

In response to this:

Bug 2091806: pkg/cvo: Separate payload load from payload apply

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@jottofar: This pull request references Bugzilla bug 2091806, which is valid.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.9.z) matches configured target release for branch (4.9.z)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
• dependent bug Bugzilla bug 2064991 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
• dependent Bugzilla bug 2064991 targets the "4.10.z" release, which is one of the valid target releases: 4.10.0, 4.10.z
• bug has dependents

Requesting review from QA contact:
/cc @jiajliu

Details

In response to this:

Bug 2091806: pkg/cvo: Separate payload load from payload apply

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@jottofar: This pull request references Bugzilla bug 2091806, which is valid.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.9.z) matches configured target release for branch (4.9.z)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
• dependent bug Bugzilla bug 2064991 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
• dependent Bugzilla bug 2064991 targets the "4.10.z" release, which is one of the valid target releases: 4.10.0, 4.10.z
• bug has dependents

Requesting review from QA contact:
/cc @jiajliu

Details

In response to this:

Bug 2091806: pkg/cvo: Separate payload load from payload apply

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@jottofar: This pull request references Bugzilla bug 2091806, which is valid.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.9.z) matches configured target release for branch (4.9.z)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
• dependent bug Bugzilla bug 2064991 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
• dependent Bugzilla bug 2064991 targets the "4.10.z" release, which is one of the valid target releases: 4.10.0, 4.10.z
• bug has dependents

Requesting review from QA contact:
/cc @jiajliu

Details

In response to this:

Bug 2091806: pkg/cvo: Separate payload load from payload apply

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@jottofar: This pull request references Bugzilla bug 2091806, which is valid.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.9.z) matches configured target release for branch (4.9.z)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
• dependent bug Bugzilla bug 2064991 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
• dependent Bugzilla bug 2064991 targets the "4.10.z" release, which is one of the valid target releases: 4.10.0, 4.10.z
• bug has dependents

Requesting review from QA contact:
/cc @jiajliu

Details

In response to this:

Bug 2091806: pkg/cvo: Separate payload load from payload apply

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@jottofar: An error was encountered querying GitHub for users with public email (jiajliu@redhat.com) for bug 2091806 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message.

non-200 OK status code: 403 Forbidden body: "{\n \"documentation_url\": \"https://docs.github.com/en/free-pro-team@latest/rest/overview/resources-in-the-rest-api#secondary-rate-limits\",\n \"message\": \"You have exceeded a secondary rate limit. Please wait a few minutes before you try again.\"\n}\n"

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

Details

In response to this:

Bug 2091806: pkg/cvo: Separate payload load from payload apply

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jottofar]

/test golangci-lint

[jottofar]

/retest

[openshift-ci]

@jottofar: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[LalatenduMohanty]

/lgtm

[LalatenduMohanty]

/label backport-risk-assessed

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jottofar, LalatenduMohanty

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [LalatenduMohanty,jottofar]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jiajliu]

/label cherry-pick-approved

[openshift-ci]

@jottofar: All pull requests linked via external trackers have merged:

• openshift/cluster-version-operator#786

Bugzilla bug 2091806 has been moved to the MODIFIED state.

Details

In response to this:

Bug 2091806: pkg/cvo: Separate payload load from payload apply

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.