lib/validation: Drop "a previous version" from desiredUpdate validation#888
Conversation
openshift-ci
Bot
added
the
approved
wking
changed the title
Narrowly catching up with c80bd02 (pkg/cvo/updatepayload: Drop history from target pullspec lookup, 2021-11-03, openshift#684), which removed that option from the implementation. Having the validation code living so far from the implementation code makes us more vulnerable to this kind of divergence, but I'll leave larger refactorings to follow-up work.
wking
force-pushed
the
drop-previous-version-reference
branch
from
e866b29 to
7690401
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: petr-muller, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
/override ci/prow/e2e-agnostic-upgrade-into-change Both results only failed on disruption tests and the OLM breakage-du-jour |
|
@petr-muller: Overrode contexts on behalf of petr-muller: ci/prow/e2e-agnostic-upgrade-into-change, ci/prow/e2e-agnostic-upgrade-out-of-change DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/hold Revision 7690401 was retested 3 times: holding |
openshift-ci
Bot
added
the
do-not-merge/hold
|
/hold cancel |
openshift-ci
Bot
removed
the
do-not-merge/hold
|
@petr-muller: Overrode contexts on behalf of petr-muller: ci/prow/e2e-agnostic-upgrade-into-change, ci/prow/e2e-agnostic-upgrade-out-of-change DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@wking: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
4 participants
Narrowly catching up with c80bd02 (#684, 4.10), which removed that option from the implementation. Having the validation code living so far from the implementation code makes us more vulnerable to this kind of divergence, but I'll leave larger refactorings to follow-up work.