pkg/cvo: code cleanups #902
Conversation
openshift-ci
bot
added
the
approved
|
/retest |
3 similar comments
|
/retest |
|
/retest |
|
/retest |
|
/override ci/prow/e2e-agnostic-upgrade-out-of-change |
|
@petr-muller: Overrode contexts on behalf of petr-muller: ci/prow/e2e-agnostic-upgrade-out-of-change DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/override ci/prow/e2e-agnostic-upgrade-into-change |
|
@petr-muller: Overrode contexts on behalf of petr-muller: ci/prow/e2e-agnostic-upgrade-into-change DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-merge-robot
added
the
needs-rebase
Fix a bunch of smells I encountered while working on openshift#896. Mostly simplify method signatures, but also remove two unused methods.
petr-muller
force-pushed
the
syncworker-cleanup
branch
from
d581a97 to
854e24e
Compare
openshift-merge-robot
removed
the
needs-rebase
|
/retest |
|
/override ci/prow/e2e-agnostic-upgrade-out-of-change |
|
@petr-muller: Overrode contexts on behalf of petr-muller: ci/prow/e2e-agnostic-upgrade-out-of-change DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@petr-muller: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LalatenduMohanty, petr-muller The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3 participants
Fix minor code issues I encountered while working on #896. Mostly simplify method signatures, but also remove two unused methods.