OCPBUGS-12182: Update dnsPolicy to allow consistent resolution of the internal LB by petr-muller · Pull Request #931 · openshift/cluster-version-operator

petr-muller · 2023-04-20T11:25:24Z

This is a cherry-pick of #923

The 8af3ba9 commit did not apply cleanly and I had to manually adjust for missing #839 and #860, but the changes were not that invasive, so I do not consider the resulting change to be too risky compared to #923

The kubelet consistently resolves the name. This change allows the CVO to use the kubelet's DNS configuration.

openshift-ci · 2023-04-20T11:25:52Z

@petr-muller: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

Update dnsPolicy to allow consistent resolution of the internal LB

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

petr-muller · 2023-04-20T11:26:39Z

/jira cherrypick OCPBUGS-11435

openshift-ci-robot · 2023-04-20T11:26:47Z

@petr-muller: Jira Issue OCPBUGS-11435 has been cloned as Jira Issue OCPBUGS-12182. Will retitle bug to link to clone.
/retitle OCPBUGS-12182: Update dnsPolicy to allow consistent resolution of the internal LB

Details

In response to this:

/jira cherrypick OCPBUGS-11435

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-04-20T11:27:10Z

@petr-muller: This pull request references Jira Issue OCPBUGS-12182, which is invalid:

expected dependent Jira Issue OCPBUGS-11435 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is a cherry-pick of #923

The 8af3ba9 commit did not apply cleanly and I had to manually adjust for missing #839 and #860, but the changes were not that invasive, so I do not consider the resulting change to be too risky compared to #923

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2023-04-20T11:27:19Z

@petr-muller: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

OCPBUGS-12182: Update dnsPolicy to allow consistent resolution of the internal LB

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Globals cause problems for unit tests (demonstrated in some of the unit tests) and prevent general reuse. The anti-pattern is avoided in kuberentes code and should be OCP as well. This updates to providing a configured condition registry without init blocks and provides a standard clustercondition registry for each consumption.

We do this so that our host-network pod can use the node's resolv.conf to resolve the internal load balancer name on the pod before DNS pods are available and before the service network is available. The side effect is that the CVO cannot resolve service DNS names.

petr-muller · 2023-04-20T11:42:15Z

TestCVO_UpgradeFailedPayloadLoadWithCapsChanges flake was only fixed in 4.13
/test unit

petr-muller · 2023-04-20T14:18:15Z

/retest

All failures seem unrelated

petr-muller · 2023-04-21T09:59:36Z

/test unit

openshift-ci · 2023-04-21T10:06:58Z

@petr-muller: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

petr-muller · 2023-04-28T10:17:14Z

/jira refresh

openshift-ci-robot · 2023-04-28T10:17:21Z

@petr-muller: This pull request references Jira Issue OCPBUGS-12182, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.12.z) matches configured target version for branch (4.12.z)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
dependent bug Jira Issue OCPBUGS-11435 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
dependent Jira Issue OCPBUGS-11435 targets the "4.13.0" version, which is one of the valid target versions: 4.13.0
bug has dependents

Requesting review from QA contact:
/cc @jiajliu

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

LalatenduMohanty · 2023-05-02T11:19:34Z

/label backport-risk-assessed

LalatenduMohanty

/lgtm

openshift-ci · 2023-05-02T12:30:58Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LalatenduMohanty, petr-muller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [LalatenduMohanty]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

petr-muller · 2023-05-03T11:48:06Z

@jianlinliu @jiajliu PTAL for cherry-pick-approved

evakhoni · 2023-05-03T16:02:03Z

/uncc @jiajliu
/cc @shellyyang1989

shellyyang1989 · 2023-05-04T09:41:37Z

/label qe-approved

as pre-merge test passed

jianlinliu · 2023-05-04T10:49:40Z

/label cherry-pick-approved

openshift-ci-robot · 2023-05-04T10:54:59Z

@petr-muller: Jira Issue OCPBUGS-12182: All pull requests linked via external trackers have merged:

openshift/cluster-version-operator#931

Jira Issue OCPBUGS-12182 has been moved to the MODIFIED state.

Details

In response to this:

This is a cherry-pick of #923

The 8af3ba9 commit did not apply cleanly and I had to manually adjust for missing #839 and #860, but the changes were not that invasive, so I do not consider the resulting change to be too risky compared to #923

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-merge-robot · 2023-05-05T23:42:41Z

Fix included in accepted release 4.12.0-0.nightly-2023-05-05-162250

Update dnsPolicy to allow consistent resolution of the internal LB

5602fa1

The kubelet consistently resolves the name. This change allows the CVO to use the kubelet's DNS configuration.

openshift-ci Bot changed the title ~~Update dnsPolicy to allow consistent resolution of the internal LB~~ OCPBUGS-12182: Update dnsPolicy to allow consistent resolution of the internal LB Apr 20, 2023

openshift-ci Bot requested review from LalatenduMohanty and wking April 20, 2023 11:27

deads2k added 2 commits April 20, 2023 13:30

petr-muller force-pushed the cherry-pick-920-to-release-4.12 branch from 13e9d86 to f9659cc Compare April 20, 2023 11:31

openshift-ci Bot requested a review from jiajliu April 28, 2023 10:17

openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label May 2, 2023

LalatenduMohanty approved these changes May 2, 2023

View reviewed changes

openshift-ci Bot assigned LalatenduMohanty May 2, 2023

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 2, 2023

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 2, 2023

openshift-ci Bot requested review from shellyyang1989 and removed request for jiajliu May 3, 2023 16:02

openshift-ci Bot added the qe-approved Signifies that QE has signed off on this PR label May 4, 2023

openshift-ci Bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label May 4, 2023

openshift-merge-robot merged commit f2620f6 into openshift:release-4.12 May 4, 2023

Conversation

petr-muller commented Apr 20, 2023

Uh oh!

openshift-ci Bot commented Apr 20, 2023

Uh oh!

petr-muller commented Apr 20, 2023

Uh oh!

openshift-ci-robot commented Apr 20, 2023

Uh oh!

openshift-ci-robot commented Apr 20, 2023

Uh oh!

openshift-ci Bot commented Apr 20, 2023

Uh oh!

petr-muller commented Apr 20, 2023

Uh oh!

petr-muller commented Apr 20, 2023

Uh oh!

petr-muller commented Apr 21, 2023

Uh oh!

openshift-ci Bot commented Apr 21, 2023

Uh oh!

petr-muller commented Apr 28, 2023

Uh oh!

openshift-ci-robot commented Apr 28, 2023

Uh oh!

LalatenduMohanty commented May 2, 2023

Uh oh!

LalatenduMohanty left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci Bot commented May 2, 2023

Uh oh!

petr-muller commented May 3, 2023

Uh oh!

evakhoni commented May 3, 2023

Uh oh!

shellyyang1989 commented May 4, 2023

Uh oh!

jianlinliu commented May 4, 2023

Uh oh!

openshift-ci-robot commented May 4, 2023

Uh oh!

openshift-merge-robot commented May 5, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants