Skip to content

[WIP] OCPVE-659: bump openshift/api#977

Merged
openshift-ci[bot] merged 2 commits intoopenshift:masterfrom
qJkee:OCPVE-659
Oct 3, 2023
Merged

[WIP] OCPVE-659: bump openshift/api#977
openshift-ci[bot] merged 2 commits intoopenshift:masterfrom
qJkee:OCPVE-659

Conversation

@qJkee
Copy link
Copy Markdown
Contributor

@qJkee qJkee commented Oct 2, 2023

bump openshift/api package with new capabilities

qJkee added 2 commits October 2, 2023 11:16
@qJkee
vendor: bump openshift/api
69c4705 
go get -u github.com/openshift/api@master
go mod tidy
go mod vendor
git add -A go.* vendor
@qJkee
update tests with new capabilities
78d6cf4 
update tests with new capabilities brought by
new version of openshift/api package
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 2, 2023
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Oct 2, 2023 •
edited by openshift-ci Bot
Loading

@qJkee: This pull request references OCPVE-659 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

Details

In response to this:

bump openshift/api package with new capabilities

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

petr-muller
petr-muller approved these changes Oct 3, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@petr-muller petr-muller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Out of change update failure is expected:

/override e2e-agnostic-ovn-upgrade-out-of-change

@petr-muller
Copy link
Copy Markdown
Member

petr-muller commented Oct 3, 2023

/override ci/prow/e2e-agnostic-ovn-upgrade-out-of-change

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Oct 3, 2023
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Oct 3, 2023 •
edited by openshift-ci Bot
Loading

@qJkee: This pull request references OCPVE-659 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

Details

In response to this:

bump openshift/api package with new capabilities

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Oct 3, 2023

@petr-muller: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • e2e-agnostic-ovn-upgrade-out-of-change

Only the following failed contexts/checkruns were expected:

  • ci/prow/e2e-agnostic-operator
  • ci/prow/e2e-agnostic-ovn
  • ci/prow/e2e-agnostic-ovn-upgrade-into-change
  • ci/prow/e2e-agnostic-ovn-upgrade-out-of-change
  • ci/prow/e2e-hypershift
  • ci/prow/e2e-hypershift-conformance
  • ci/prow/gofmt
  • ci/prow/images
  • ci/prow/lint
  • ci/prow/unit
  • pull-ci-openshift-cluster-version-operator-master-e2e-agnostic-operator
  • pull-ci-openshift-cluster-version-operator-master-e2e-agnostic-ovn
  • pull-ci-openshift-cluster-version-operator-master-e2e-agnostic-ovn-upgrade-into-change
  • pull-ci-openshift-cluster-version-operator-master-e2e-agnostic-ovn-upgrade-out-of-change
  • pull-ci-openshift-cluster-version-operator-master-e2e-hypershift
  • pull-ci-openshift-cluster-version-operator-master-e2e-hypershift-conformance
  • pull-ci-openshift-cluster-version-operator-master-gofmt
  • pull-ci-openshift-cluster-version-operator-master-images
  • pull-ci-openshift-cluster-version-operator-master-lint
  • pull-ci-openshift-cluster-version-operator-master-unit
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

Details

In response to this:

LGTM. Out of change update failure is expected:

/override e2e-agnostic-ovn-upgrade-out-of-change

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Oct 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: petr-muller, qJkee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 3, 2023
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Oct 3, 2023 •
edited by openshift-ci Bot
Loading

@qJkee: This pull request references OCPVE-659 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

Details

In response to this:

bump openshift/api package with new capabilities

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot
Copy link
Copy Markdown
Contributor

openshift-merge-robot commented Oct 3, 2023

@qJkee: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Oct 3, 2023

@petr-muller: Overrode contexts on behalf of petr-muller: ci/prow/e2e-agnostic-ovn-upgrade-out-of-change

Details

In response to this:

/override ci/prow/e2e-agnostic-ovn-upgrade-out-of-change

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Oct 3, 2023

@qJkee: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci Bot merged commit 3019843 into openshift:master Oct 3, 2023
@eggfoobar eggfoobar mentioned this pull request Oct 3, 2023
Merged
@qJkee
Copy link
Copy Markdown
Contributor Author

qJkee commented Oct 5, 2023

/reopen

@qJkee qJkee changed the title OCPVE-659: bump openshift/api [WIP] OCPVE-659: bump openshift/api Oct 5, 2023
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 5, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Oct 5, 2023

@qJkee: Failed to re-open PR: state cannot be changed. The pull request cannot be reopened.

Details

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DavidHurta DavidHurta Awaiting requested review from DavidHurta

@LalatenduMohanty LalatenduMohanty Awaiting requested review from LalatenduMohanty

1 more reviewer

@petr-muller petr-muller petr-muller approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@petr-muller petr-muller

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@qJkee @openshift-ci-robot @petr-muller @openshift-merge-robot