Bug 1746103: Fix secret in pod log in 4.1 by benjaminapetersen · Pull Request #278 · openshift/console-operator

benjaminapetersen · 2019-08-28T20:39:52Z

Related to Bug 1737315: Fix secret in pod log #276
Bump to library-go handles this per @spadgett comment on bugzilla, ref [release-4.1] Bug 1734622: resourceapply: don't log secret data library-go#472
Pins glide.yaml to release-4.1 for all openshift related repos.

openshift-ci-robot · 2019-08-28T20:40:11Z

@benjaminapetersen: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

Bug 1746103

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2019-08-28T20:40:34Z

@benjaminapetersen: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

Bug 1746103

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

benjaminapetersen · 2019-08-28T20:40:58Z

/bugzilla refresh

openshift-ci-robot · 2019-08-28T20:40:59Z

@benjaminapetersen: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

benjaminapetersen · 2019-08-28T20:43:27Z

/retest

sfowl · 2019-08-29T00:40:54Z

@benjaminapetersen Looks like this PR has not triggered a bugzilla update. Maybe a ':' suffix in the PR title and /bugzilla retest is needed?

openshift-ci-robot · 2019-08-29T08:26:34Z

@benjaminapetersen: This pull request references Bugzilla bug 1746103, which is invalid:

expected dependent Bugzilla bug 1737315 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1746103:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jhadvig · 2019-08-29T08:27:31Z

/bugzilla refresh

openshift-ci-robot · 2019-08-29T08:27:34Z

@jhadvig: This pull request references Bugzilla bug 1746103, which is invalid:

expected dependent Bugzilla bug 1737315 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jhadvig · 2019-08-29T08:28:23Z

/bugzilla retest

benjaminapetersen · 2019-08-29T14:08:58Z

/retest

- Update OperatorStatusTypeFailing to OperatorStatusTypeDegraded in status.go

benjaminapetersen · 2019-08-29T14:20:55Z

 func (c *consoleOperator) ConditionResourceSyncSuccess(operatorConfig *operatorsv1.Console) *operatorsv1.Console {
 	v1helpers.SetOperatorCondition(&operatorConfig.Status.Conditions, operatorsv1.OperatorCondition{
-		Type:               operatorsv1.OperatorStatusTypeFailing,
+		Type:               operatorsv1.OperatorStatusTypeDegraded,


This is the only modification required in operator code.

benjaminapetersen · 2019-08-29T14:22:04Z

/bugzilla refresh

openshift-ci-robot · 2019-08-29T14:22:07Z

@benjaminapetersen: This pull request references Bugzilla bug 1746103, which is invalid:

expected dependent Bugzilla bug 1737315 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

benjaminapetersen · 2019-08-29T14:24:59Z

Bugzilla won't update https://bugzilla.redhat.com/show_bug.cgi?id=1746103 until the original bug for 4.2 https://bugzilla.redhat.com/show_bug.cgi?id=1737315 is validated.

One update made to operator code to fix a dependency caused reference change. Tests should pass now.

benjaminapetersen · 2019-08-29T18:44:09Z

/retest

spadgett

/lgtm

spadgett · 2019-08-30T16:39:37Z

+  version: release-4.1

-# codegen
+  # codegen


nit: unintentional whitespace change?

jhadvig

/lgtm

openshift-ci-robot · 2019-09-02T08:35:40Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benjaminapetersen, jhadvig, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [benjaminapetersen,spadgett]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2019-09-05T13:44:09Z

@benjaminapetersen: All pull requests linked via external trackers have merged. Bugzilla bug 1746103 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1746103: Fix secret in pod log in 4.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Bump library-go to fix bug 1737315 - secrets in pod log

2f92c7b

openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 28, 2019

benjaminapetersen changed the base branch from master to release-4.1 August 28, 2019 20:40

openshift-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 28, 2019

openshift-ci-robot requested review from jhadvig and spadgett August 28, 2019 20:40

benjaminapetersen closed this Aug 28, 2019

benjaminapetersen reopened this Aug 28, 2019

openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 28, 2019

jhadvig changed the title ~~Bug 1746103~~ Bug 1746103: Aug 29, 2019

openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Aug 29, 2019

benjaminapetersen changed the title ~~Bug 1746103:~~ Bug 1746103: Fix secret in pod log in 4.1 Aug 29, 2019

Fixes in response to pinning openshift dependency repos to 4.1

fdefa6d

- Update OperatorStatusTypeFailing to OperatorStatusTypeDegraded in status.go

benjaminapetersen force-pushed the release/4.1/bug-1737315/bump branch from 790ceb0 to fdefa6d Compare August 29, 2019 14:20

benjaminapetersen commented Aug 29, 2019

View reviewed changes

spadgett approved these changes Aug 30, 2019

View reviewed changes

Comment thread glide.yaml

version: release-4.1

# codegen

# codegen

Copy link
Copy Markdown

Member

spadgett Aug 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: unintentional whitespace change?

openshift-ci-robot assigned spadgett Aug 30, 2019

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 30, 2019

jhadvig approved these changes Sep 2, 2019

View reviewed changes

openshift-ci-robot assigned jhadvig Sep 2, 2019

jhadvig merged commit 22c3086 into openshift:release-4.1 Sep 5, 2019

benjaminapetersen deleted the release/4.1/bug-1737315/bump branch September 5, 2019 15:15

spadgett added this to the v4.1.z milestone Sep 26, 2019

Conversation

benjaminapetersen commented Aug 28, 2019

Uh oh!

openshift-ci-robot commented Aug 28, 2019

Uh oh!

openshift-ci-robot commented Aug 28, 2019

Uh oh!

benjaminapetersen commented Aug 28, 2019

Uh oh!

openshift-ci-robot commented Aug 28, 2019

Uh oh!

benjaminapetersen commented Aug 28, 2019

Uh oh!

sfowl commented Aug 29, 2019

Uh oh!

openshift-ci-robot commented Aug 29, 2019

Uh oh!

jhadvig commented Aug 29, 2019

Uh oh!

openshift-ci-robot commented Aug 29, 2019

Uh oh!

jhadvig commented Aug 29, 2019

Uh oh!

benjaminapetersen commented Aug 29, 2019

Uh oh!

benjaminapetersen Aug 29, 2019

Choose a reason for hiding this comment

Uh oh!

benjaminapetersen commented Aug 29, 2019

Uh oh!

openshift-ci-robot commented Aug 29, 2019

Uh oh!

benjaminapetersen commented Aug 29, 2019

Uh oh!

benjaminapetersen commented Aug 29, 2019

Uh oh!

spadgett left a comment

Choose a reason for hiding this comment

Uh oh!

spadgett Aug 30, 2019

Choose a reason for hiding this comment

Uh oh!

jhadvig left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci-robot commented Sep 2, 2019

Uh oh!

openshift-ci-robot commented Sep 5, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants