Skip to content

Reorganize args to NewConsoleOperator func #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Oct 9, 2019
Merged

Reorganize args to NewConsoleOperator func #310

openshift-merge-robot merged 1 commit into from
Oct 9, 2019

Conversation

@benjaminapetersen
Copy link
Contributor

@benjaminapetersen benjaminapetersen commented Oct 8, 2019

Reorganize args to NewConsoleOperator() to fit client/informer sets together.

This will make it easier to extract out components into separate controllers.

/assign @jhadvig

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 8, 2019
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 8, 2019
@benjaminapetersen
Copy link
Contributor Author

benjaminapetersen commented Oct 8, 2019

/retest

@benjaminapetersen
Copy link
Contributor Author

benjaminapetersen commented Oct 8, 2019

/retest

level=fatal msg="failed to initialize the cluster: Cluster operator image-registry is still updating"

@benjaminapetersen
Copy link
Contributor Author

benjaminapetersen commented Oct 9, 2019

/retest

@jhadvig
Copy link
Member

jhadvig commented Oct 9, 2019 •
edited
Loading 

[WARNING] !!! gofmt needs to be run on the listed files
./pkg/console/starter/starter.go

@benjaminapetersen benjaminapetersen force-pushed the controllers/new-console-operator-refactor branch from de64460 to e3b1d62 Compare October 9, 2019 13:57
@benjaminapetersen
Copy link
Contributor Author

benjaminapetersen commented Oct 9, 2019

/retest

level=fatal msg="failed to fetch Cluster: failed to generate asset \"Cluster\": failed to create cluster: failed to apply using Terraform"

jhadvig
jhadvig approved these changes Oct 9, 2019
View reviewed changes
Copy link
Member

@jhadvig jhadvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 9, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 9, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benjaminapetersen, jhadvig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 44181c8 into openshift:master Oct 9, 2019
@benjaminapetersen benjaminapetersen deleted the controllers/new-console-operator-refactor branch October 9, 2019 20:26
@benjaminapetersen benjaminapetersen mentioned this pull request Nov 6, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhadvig jhadvig jhadvig approved these changes

@spadgett spadgett Awaiting requested review from spadgett

Assignees

@jhadvig jhadvig

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@benjaminapetersen @jhadvig @openshift-ci-robot @openshift-merge-robot