Skip to content

Add ROKS profile annotation to recently added manifests #491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Dec 3, 2020
Merged

Add ROKS profile annotation to recently added manifests #491

openshift-merge-robot merged 1 commit into from
Dec 3, 2020

Conversation

@csrwng
Copy link
Contributor

@csrwng csrwng commented Nov 30, 2020

Adds ROKS profile annotation to recently added manifests (#479)

spadgett
spadgett approved these changes Nov 30, 2020
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 30, 2020
jhadvig
jhadvig approved these changes Dec 1, 2020
View reviewed changes
Copy link
Member

@jhadvig jhadvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/retest

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 1, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csrwng, jhadvig, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 1, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@jhadvig
Copy link
Member

jhadvig commented Dec 1, 2020 

error: some steps failed:
  * could not run steps: step e2e-aws-operator failed: "e2e-aws-operator" post steps failed: ["e2e-aws-operator" pod "e2e-aws-operator-gather-must-gather" failed: the pod ci-op-nhy75ljx/e2e-aws-operator-gather-must-gather failed after 11m32s (failed containers: test): ContainerFailed one or more containers exited

Container test exited with code 1, reason Error
---
Running must-gather...
error: gather did not start for pod must-gather-bsn2l: timed out waiting for the condition
error: failed to execute wrapped command: exit status 1
---
Link to step on registry info site: https://steps.ci.openshift.org/reference/gather-must-gather
Link to job on registry info site: https://steps.ci.openshift.org/job?org=openshift&repo=console-operator&branch=master&test=e2e-aws-operator, "e2e-aws-operator" pod "e2e-aws-operator-gather-audit-logs" failed: the pod ci-op-nhy75ljx/e2e-aws-operator-gather-audit-logs failed after 11m34s (failed containers: test): ContainerFailed one or more containers exited

Container test exited with code 1, reason Error

/retest

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 1, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 2, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 2, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@jhadvig
Copy link
Member

jhadvig commented Dec 2, 2020 

=== RUN   TestRemoved
    removed_test.go:11: waiting for setup to reach settled state...
    removed_test.go:26: changing console operator state to 'Removed'...
    removed_test.go:27: validating that the operator does not recreate removed resources when ManagementState:Removed...
validating console resources have been removed... false
validating console resources have been removed... false
validating console resources have been removed... false
    removed_test.go:30: deleted console Deployment console was recreated:

@jhadvig
Copy link
Member

jhadvig commented Dec 2, 2020

/test e2e-aws-operator

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 2, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

12 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 2, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 2, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 2, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 2, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 2, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 2, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 2, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 2, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 2, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 3, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 3, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 3, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 3, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 3, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 3, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 3, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 3, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 3, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 430b4e3 into openshift:master Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spadgett spadgett spadgett approved these changes

@jhadvig jhadvig jhadvig approved these changes

Assignees

@spadgett spadgett

@jhadvig jhadvig

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@csrwng @openshift-ci-robot @openshift-bot @jhadvig @spadgett @openshift-merge-robot